Skip to content
Snippets Groups Projects

Rego functions for cache write and read (set and get)

Merged Rego functions for cache write and read (set and get)
17-rego-cache-functions into main
All threads resolved!
Merged Lyuben Penkovski requested to merge 17-rego-cache-functions into main
All threads resolved!

I've put the cache functions in a more generic regofunc package so that we can retrieve them from one place.

With the previous design where cache functions were placed in the CacheExt struct it had a nice separation of concerns, but IMO it would make it more difficult when we create new built-in functions, because we would have to create multiple objects to retrieve the different functions. Please share your thoughts on this if you have objections.

Closes #17 (closed)

@valerii.kalashnikov

Edited by Lyuben Penkovski

Merge request reports

Pipeline #50395 passed

Stage:

    Pipeline passed for 373039bc on 17-rego-cache-functions

    Test coverage 83.30% (-7.40%) from 1 job
    Approval is optional

    Merged by Lyuben PenkovskiLyuben Penkovski 3 years ago (Apr 27, 2022 9:21am UTC)

    Merge details

    Pipeline #50396 passed

    Stage:

      Pipeline passed for 0ec7620c on main

      Test coverage 83.30% (-7.40%) from 1 job

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Lyuben Penkovski added 3 commits

      added 3 commits

      • e0453d30 - ref #17 (closed). Use factory approach to initialize the rego functions
      • b8ee3408 - Rename some variables and fix the tests
      • 373039bc - Merge branch 'vkalashnikov/17-rego-cache-functions' into '17-rego-cache-functions'

      Compare with previous version

    • Lyuben Penkovski resolved all threads

      resolved all threads

    • Yordan Kinkov resolved all threads

      resolved all threads

    • Yordan Kinkov
      Yordan Kinkov @yordan.kinkov ·
      Maintainer

      LGTM

    • Lyuben Penkovski merged

      merged

    • Lyuben Penkovski mentioned in commit 0ec7620c

      mentioned in commit 0ec7620c

      • Please register or sign in to reply