Skip to content
Snippets Groups Projects
  1. Mar 10, 2015
  2. Mar 09, 2015
  3. Mar 06, 2015
  4. Mar 05, 2015
  5. Mar 02, 2015
    • Jared Hancock's avatar
      Revert "filter: Fix filtering by list item properties" · 3331b720
      Jared Hancock authored
      This partially reverts commit bff191b6.
      The hasSpecialSearch() method can be retired in `develop-next` — NOT in the
      `develop` branch
      3331b720
    • Jared Hancock's avatar
      oops: Fix corruption of thread body posted by collabs · b143ea6f
      Jared Hancock authored
      If the system receives an email by a collaborator which has not yet been
      added to the ticket (a friend of a friend — that is, a collaborator forwards
      an email to a third-party), a header is added to the thread body something
      like:
      
      Received From: afriendofafriend@mycompany.tld
      
      However, if the thread body is text and the HTML ticket thread is enabled,
      then the text formatting hint will be lost and the body will be assumed as
      HTML deeper inside the thread entry creation process. Therefore, the
      whitespace inside the resulting thread entry will be collapsed.
      
      This patch addresses the issue by maintaining the original format hint with
      the thread body.
      b143ea6f
  6. Feb 27, 2015
  7. Feb 26, 2015
  8. Feb 18, 2015
  9. Feb 17, 2015
  10. Feb 16, 2015
  11. Feb 13, 2015
  12. Feb 12, 2015
    • Jared Hancock's avatar
      thread: Fix a couple issues with email message-ids · ae603f80
      Jared Hancock authored
        * Fix matching of collaborators on return emails. Previously the
          collaborator ID was used instead of the related user ID. Also, the 'C'
          user class (collaborator) was not handled in ::decodeMessageId()
        * Only send a reply separator for email related to a thread
        * Always generate a tag for the email message id. This will allow reply
          from the help desk administrator for the new ticket alert
      ae603f80
  13. Feb 11, 2015
    • Peter Rotich's avatar
      Merge pull request #1727 from greezybacon/issue/login-dos · ca79bd5c
      Peter Rotich authored
      
      login: Require CSRF token to login
      
      Reviewed-By: default avatarPeter Rotich <peter@osticket.com>
      ca79bd5c
    • Jared Hancock's avatar
      oops: Fix truncated random data · ca970b2a
      Jared Hancock authored
      ca970b2a
    • Jared Hancock's avatar
      login: Require CSRF token to login · 504831fe
      Jared Hancock authored
      This patch fixes a vulnerable scenario, where sequential login attempts can
      be made without an existing session, and without a valid CSRF token. This
      scenario lends itself well for brute force password attempts, because
      attackers can avoid using a session and still send requests to determine if
      a set of credentials are valid. This vector also avoids the authentication
      lockout mechanism, because it requires an ongoing session to shutdown the
      requests.
      
      This patch addresses the issue by requiring a session and a valid CSRF token
      generated by the server and placed in the session to be submitted with the
      credentials. Therefore, an existing session and a Cookie header are required
      to process a login attempt. Secondly, the CSRF token will be changed on the
      server after each login processed. Therefore, for each session, a subsequent
      GET request would be necessary before submitting another login attempt.
      504831fe
Loading