- May 01, 2014
-
-
Jared Hancock authored
-
Jared Hancock authored
-
- Apr 30, 2014
-
-
Peter Rotich authored
tnef: Fix major issue iterating over attar streams Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
The original logic would read the count of attributes in the stream and then read the first attribute in the constructor of TnefAttributeStreamReader. Then the iterator interface would call ::rewind() before iterating to the first item. rewind() set the @pos attribute to zero, which would cause the attribute count (4-byte int) to be interpreted incorrectly as part of the first attribute. The new logic sets the position at 4 after rewind()ing, and does not read the first attribute twice. It also properly detects the end of the attribute stream by the number of attributes advertised as the first four bytes of the stream (read into the @count attribute initially).
-
- Apr 29, 2014
-
-
Jared Hancock authored
-
Peter Rotich authored
storage: Avoid using `strlen` to count bytes Reviewed-By:
Peter Rotich <peter@osticket.com>
-
- Apr 28, 2014
-
-
Jared Hancock authored
-
Jared Hancock authored
Fix wrong ticket count on basic ticket search Reviewed-By:
Jared Hancock <jared@osticket.com>
-
Peter Rotich authored
bad links fixed Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
On validation errors, `$faq` will be set to something non-null, like `false`, but will not be an instance of a Faq article.
-
Jared Hancock authored
For PHP installations that have `mbstring.func_overload` enabled (set to a value including `2`), the `strlen` function will be overloaded to use the `mb_strlen` equivalent. Problematically, the internal encoding of `UTF-8` will be applied to all file content, which will count UTF-8 characters rather than bytes. This will cause the data to be saved correctly; however, the `size` recorded in the %file table will be recorded incorrectly. This patch allows the backend to report the size of the contents saved with the request and provides a failsafe mechanism which will use the mbstring equivalent if available, and the mbstring version is coded to use the `8bit` as the encoding which will prevent reading characters. References: https://github.com/osTicket/osTicket-1.8/issues/552
-
Peter Rotich authored
Basic search is now limited to ticket number, email address and name.
-
NoobPsyBot authored
-
- Apr 25, 2014
-
-
Jared Hancock authored
Show more drop down for users with edit permission Reviewed-By:
Jared Hancock <jared@osticket.com>
-
- Apr 24, 2014
-
-
Peter Rotich authored
Users with edit permission should be able to change ticket owner in line.
-
- Apr 23, 2014
-
-
Jared Hancock authored
Clear settings on department deletion Reviewed-By:
Jared Hancock <jared@osticket.com>
-
Peter Rotich authored
Clear ticket routing settings on topic, email or filter tables on department deletion.
-
- Apr 18, 2014
-
-
Peter Rotich authored
ui: Fixup unnecessary extra spacing in thread body Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
html: Avoid corrupting quoted style attributes Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
-
- Apr 16, 2014
-
-
Jared Hancock authored
-
Jared Hancock authored
For instance, current this style we be converted as ``` <span style="font-family:'courier new';"> ``` to ``` <span style="font-family:""> ``` Also discard Microsoft Office specific style attributes such as `mso-list` and friends
-
- Apr 15, 2014
-
-
Jared Hancock authored
-
- Apr 14, 2014
-
-
Jared Hancock authored
This stems from a confusing similarity between the + operator for arrays and array_merge() in php. Adding arrays will ignore items in the RHS where keys are present in the LHS. Therefore, when adding numerically indexed arrays together, only items on the RHS that have a key higher than the greatest key on the LHS will be included.
-
Jared Hancock authored
-
Jared Hancock authored
It is perfectectly fine to have an image cited in an HTML body similar to: <img width=909 height=302 src=cid:image002.jpg@01CF5426.BF5A72A0 alt=image> Which may or may not have quoted @src attribute, and may very well have an at sign (@) somewhere in the attribute text. The previous regular expression would not match such a @src attribute.
-
Peter Rotich authored
Inline images in email without a 'cid:' indicator Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
It is the defacto standard to reference an inline image in an email by referencing the Content-ID header of the referenced attachment in the @src attribute of the image. For instance, `<imc src="cid:image001.png">` where the `cid:` scheme of the attribute indicates that the referenced image URL is a separate content of the email. The image attached to the email would have an accompanying header like: `Content-Id: <image001.png>`. However, some mail systems, including a certain fax to email service, do not correctly indicate the location of the image with the content-id URL. Instead, the referenced image tag would be `<img src="image001.png">` This patch addresses the issue by searching the message body for all references to attached content-id's in all @src attributes with or without the content-id URL scheme indicator. Previously, such images would not be displayed inline in the ticket thread. References: https://tools.ietf.org/html/rfc2392
-
Jared Hancock authored
-
- Apr 11, 2014
-
-
Peter Rotich authored
Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Peter Rotich authored
Reviewed-By:
Peter Rotich <peter@osticket.com>
-
- Apr 08, 2014
-
-
Sahab Yazdani authored
-
Jared Hancock authored
If the `view.php` page is requested and an auth token is not present in the URL, do not attempt to sign the user on since it will always fail and will result in a false "Failed login attempt" warning to the system log.
-
- Apr 04, 2014
-
-
Jared Hancock authored
-
- Apr 02, 2014
-
-
Peter Rotich authored
Reviewed-By:
Peter Rotich <peter@osticket.com>
-
Jared Hancock authored
Allow regular staff members to show assigned open tickets on open queue Reviewed-By:
Jared Hancock <jared@osticket.com>
-
Peter Rotich authored
Previously only admins and department managers could show assigned tickets on open queue -even- when the feature is disabled globally. This pull request extends the same previlege to all agents.
-
Jared Hancock authored
email: Fix inline images sent in old HTML markup Reviewed-By: @enricoandreoli Reviewed-By: @sgozzi
-
Jared Hancock authored
Such images are attached to emails by Lotus Notes. Technically, these images are valid attachments, although historically osTicket would reject them
-
Jared Hancock authored
-