Skip to content
Snippets Groups Projects
  1. Mar 23, 2015
  2. Mar 05, 2015
  3. Feb 27, 2015
  4. Feb 26, 2015
  5. Feb 18, 2015
  6. Feb 17, 2015
  7. Feb 13, 2015
  8. Feb 12, 2015
    • Jared Hancock's avatar
      Collaborators for threads, lock as a utility · 67d55198
      Jared Hancock authored
      This patch includes a slight database migration, and adjusts the
      functionality of a few core components.
      
        * Move collaborators from the ticket to the thread.
          This concept allows collaborators on any object which has a thread,
          including tasks.
      
        * Add flags to the thread entry
          This will allow flagging thread entries for different purposes.
          Initially this can be used to flag the original message of a thread in
          case a ticket / thread is created without an initial message.
      
        * Lock becomes more of a utility
          The lock is now disconnected from the ticket and is a separate utility.
          Separately, the ticket and task objects can have a reference to a lock
          object. Furthermore, when submitting some activities to tickets, the
          lock is verified to be owned by the respective agent, and the lock code
          must match a current lock code. The code is rotated on each acquire()
          call to guard against double submissions.
      
        * Collaborator is an ORM model
          The TicketUser class is broken up now so that the collaborator instance
          can exist apart from a ticket. Email message ids are now generated for
          collaborators without respect for a ticket so that collaborators can be
          properly supported on any thread.
      67d55198
  9. Feb 11, 2015
    • Jared Hancock's avatar
      login: Require CSRF token to login · 504831fe
      Jared Hancock authored
      This patch fixes a vulnerable scenario, where sequential login attempts can
      be made without an existing session, and without a valid CSRF token. This
      scenario lends itself well for brute force password attempts, because
      attackers can avoid using a session and still send requests to determine if
      a set of credentials are valid. This vector also avoids the authentication
      lockout mechanism, because it requires an ongoing session to shutdown the
      requests.
      
      This patch addresses the issue by requiring a session and a valid CSRF token
      generated by the server and placed in the session to be submitted with the
      credentials. Therefore, an existing session and a Cookie header are required
      to process a login attempt. Secondly, the CSRF token will be changed on the
      server after each login processed. Therefore, for each session, a subsequent
      GET request would be necessary before submitting another login attempt.
      504831fe
  10. Feb 06, 2015
  11. Jan 30, 2015
  12. Jan 23, 2015
  13. Jan 14, 2015
    • Jared Hancock's avatar
      Session never expires · ee072130
      Jared Hancock authored
      This patch sends updated session cookies to the browser when the session is
      refreshed on the server. This allows the session cookie to expire on the
      browser at the same time the session timeout occurs at the server. In the
      event the session timeout is configured in osTicket not to expire, the
      cookie will expire after seven days on the client browser, and will expire
      in PHP when it is garbage collected sometime after 86400 seconds after the
      time last refresh time.
      
      Using this method, the session will never expire if the session timeout in
      osTicket is configured to 0, and the session is refreshed at least daily.
      ee072130
  14. Jan 13, 2015
    • Jared Hancock's avatar
      filter: Implement several small things after discussion · 685b6480
      Jared Hancock authored
        * Add trashcan icon for newly-added actions
        * Categorize filter actions
        * Use imperative phrases for action descriptions
        * Drop check boxes from simple actions (like reject ticket)
        * Hide empty forms on new ticket pages
        * Do not store config for nondata fields for actions
        * Implement a multi-use feature for actions, which will allow using a
          action more than once (for instance, multiple email sends)
        * Filter actions are sortable
        * Send email has from address configurable
        * %{user} token is valid as a recipient
      685b6480
    • Jared Hancock's avatar
      filter: Filter 2.0 — greater extensibility · 9150e18e
      Jared Hancock authored
      This patch rebases filters into a row-based layout and redesigns the filter
      apply method to be more extensible. It also redesigns the UI to be more
      dynamic and to allow for actions to be added without database modification
      and actions can also have complex configurations.
      9150e18e
  15. Jan 12, 2015
    • Jared Hancock's avatar
      Allow new ticket without initial message · 8bdfa04f
      Jared Hancock authored
      8bdfa04f
    • Jared Hancock's avatar
      forms: Instructions can be HTML · 0e21ff48
      Jared Hancock authored
      0e21ff48
    • Jared Hancock's avatar
      Help topics have much better form configurations · 07e18dc1
      Jared Hancock authored
      Help topics can now specify one or more additional forms to be included on
      the help topic and can also specify the sort order of those forms.
      Furthermore, individual fields can be disabled per help topic, so that
      unnecessary fields can be omitted when necessary, per help topic.
      
      The disabled flag is recorded along side the field data so that the field
      will not be accidentally added to the form later automatically. There is no
      interface in this commit to enable a field which was disabled by the help
      topic when ticket was created.
      07e18dc1
  16. Dec 31, 2014
    • Jared Hancock's avatar
      files: Provide unified download script · d9cf38bc
      Jared Hancock authored
      This script adds a single download script, 'file.php', which provides access
      to files of all types to all users. It uses a HMAC signature system with an
      expires time, which allows signed URLs to be sent to external users.
      
      This also fixes an issue with the Http::cacheable() method, where the
      last-modified and Etag headers were not properly compared, which resulted in
      permanent cache misses by the client.
      d9cf38bc
    • Peter Rotich's avatar
      fixes: Review · 89c0d798
      Peter Rotich authored
      Key permissions definition array
      Move canned and faq permissions to their respective classes.
      89c0d798
  17. Dec 28, 2014
    • Peter Rotich's avatar
      Retire l.php · b647d1aa
      Peter Rotich authored
      Stop trampolining links via l.php. It was necessary before in order to avoid
      the potential of leaking ticket number & email. The authentication mechanism
      in place now redirects on successful login.
      b647d1aa
  18. Dec 22, 2014
  19. Dec 20, 2014
  20. Dec 16, 2014
    • Jared Hancock's avatar
      ui: Implement "enable canned responses" config option · d5e8ac09
      Jared Hancock authored
      This patch removes the selection of canned responses as well as the canned
      responses navigation page from the ui when the canned responses feature is
      disabled.
      d5e8ac09
    • Jared Hancock's avatar
      lock: Set ticket lock on ticket-view · 1ab0f541
      Jared Hancock authored
      Since the automatic lock was being acquired but not passed to the autoLock
      system, the automatically acquired lock was not being release on away
      navigation.
      
      This patch addresses the issue by passing the automatically acquired lock id
      to the autoLock system on ticket-view page load and change the ::Init()
      method so that the lock id is not cleared with the ::Init() method is called
      by the page load.
      1ab0f541
  21. Dec 11, 2014
Loading