Skip to content
Snippets Groups Projects
  1. May 13, 2015
  2. May 11, 2015
  3. May 08, 2015
    • Jared Hancock's avatar
      autocron: Release agent session before running · b076f503
      Jared Hancock authored
      The PHP session system will hold a lock on the session until it is released.
      It is important to release the session before performing long-running tasks
      so that further requests from the agent are not locked.
      b076f503
  4. Apr 14, 2015
  5. Apr 10, 2015
  6. Apr 02, 2015
  7. Apr 01, 2015
  8. Mar 31, 2015
  9. Mar 24, 2015
  10. Mar 18, 2015
  11. Mar 17, 2015
    • Jared Hancock's avatar
      search: Fix search on create date · 4d26f29f
      Jared Hancock authored
      This addresses the issue where the advanced search dialog was submitted
      before the date picker inputs were fixed up. This problem arises out of a
      difference between the agent's date formatting preference and the server
      being able to process that date format. The date pickers are reformated to
      yyyy-mm-dd before submission; however, for advanced search, the submission
      happened before the inputs were fixed up.
      
      This patch addresses the issue by manually fixing up the date in the
      submission routine for the advanced search dialog.
      4d26f29f
  12. Mar 12, 2015
  13. Feb 18, 2015
  14. Feb 11, 2015
    • Jared Hancock's avatar
      login: Require CSRF token to login · 504831fe
      Jared Hancock authored
      This patch fixes a vulnerable scenario, where sequential login attempts can
      be made without an existing session, and without a valid CSRF token. This
      scenario lends itself well for brute force password attempts, because
      attackers can avoid using a session and still send requests to determine if
      a set of credentials are valid. This vector also avoids the authentication
      lockout mechanism, because it requires an ongoing session to shutdown the
      requests.
      
      This patch addresses the issue by requiring a session and a valid CSRF token
      generated by the server and placed in the session to be submitted with the
      credentials. Therefore, an existing session and a Cookie header are required
      to process a login attempt. Secondly, the CSRF token will be changed on the
      server after each login processed. Therefore, for each session, a subsequent
      GET request would be necessary before submitting another login attempt.
      504831fe
  15. Feb 06, 2015
  16. Jan 14, 2015
    • Jared Hancock's avatar
      Session never expires · ee072130
      Jared Hancock authored
      This patch sends updated session cookies to the browser when the session is
      refreshed on the server. This allows the session cookie to expire on the
      browser at the same time the session timeout occurs at the server. In the
      event the session timeout is configured in osTicket not to expire, the
      cookie will expire after seven days on the client browser, and will expire
      in PHP when it is garbage collected sometime after 86400 seconds after the
      time last refresh time.
      
      Using this method, the session will never expire if the session timeout in
      osTicket is configured to 0, and the session is refreshed at least daily.
      ee072130
  17. Dec 31, 2014
    • Jared Hancock's avatar
      files: Provide unified download script · d9cf38bc
      Jared Hancock authored
      This script adds a single download script, 'file.php', which provides access
      to files of all types to all users. It uses a HMAC signature system with an
      expires time, which allows signed URLs to be sent to external users.
      
      This also fixes an issue with the Http::cacheable() method, where the
      last-modified and Etag headers were not properly compared, which resulted in
      permanent cache misses by the client.
      d9cf38bc
  18. Dec 28, 2014
    • Peter Rotich's avatar
      Retire l.php · b647d1aa
      Peter Rotich authored
      Stop trampolining links via l.php. It was necessary before in order to avoid
      the potential of leaking ticket number & email. The authentication mechanism
      in place now redirects on successful login.
      b647d1aa
  19. Dec 16, 2014
    • Jared Hancock's avatar
      ui: Implement "enable canned responses" config option · d5e8ac09
      Jared Hancock authored
      This patch removes the selection of canned responses as well as the canned
      responses navigation page from the ui when the canned responses feature is
      disabled.
      d5e8ac09
    • Jared Hancock's avatar
      lock: Set ticket lock on ticket-view · 1ab0f541
      Jared Hancock authored
      Since the automatic lock was being acquired but not passed to the autoLock
      system, the automatically acquired lock was not being release on away
      navigation.
      
      This patch addresses the issue by passing the automatically acquired lock id
      to the autoLock system on ticket-view page load and change the ::Init()
      method so that the lock id is not cleared with the ::Init() method is called
      by the page load.
      1ab0f541
  20. Oct 15, 2014
  21. Oct 10, 2014
  22. Oct 09, 2014
  23. Oct 06, 2014
  24. Oct 03, 2014
  25. Oct 02, 2014
Loading