files: Require authentication to view attachments

Reviewed-By: Peter Rotich <peter@osticket.com>

upgrader: Split change and drop into 2 statements

Reviewed-By: Jared Hancock <jared@osticket.com>

This feature adds a setting to the control panel to require signing in to
view attachments. This is in addition to the security already provided in
the download URLs. Currently, download URLs are signed for a specific help
desk, and automatically expire after about 24 hours. The exact timing is the
following midnight allowing for at least 12 hours cache time.

Administrators can impose this extra security feature to refuse serving
attachment files if the user is not currently signed in. This could prevent
third-party users from viewing an attachment if they were able to get access
to the download URL before it expired.

Department  Access and Membership

Reviewed-By: Jared Hancock <jared@osticket.com>

* Separate primary from extended access members when listing department
  access.

* Add ability to update primary department members role

* Quick staff add - inherit role of the primary department as default role

Add ability get sorted department members. Extended members are sorted, annotated
and cached.

Consolidate agents name sorting in Staff::nsort. The routing expects a query
set.

isMember routine wrongly assumed getMembers returned staff_id indexed
hashtable.

lint: Allow $this inside anonymous functions

Reviewed-By: Peter Rotich <peter@osticket.com>

Session: Create SessionData object on demand

Reviewed-By: Jared Hancock <jared@osticket.com>

Update class.auth.php

Reviewed-By: Jared Hancock <jared@osticket.com>

closed-by: Credit the agent opening a ticket on close

Reviewed-By: Jared Hancock <jared@osticket.com>

Session backend issues update via write on new session which caused
assertion to fail.

If the Return-Path header does not match the From header, emails are significantly more likely to be blocked by spam filters.

This patch forces the return header to match the from address without having to change php.ini and therefore works properly on servers that have multiple apps sending from multiple email addresses for example shared hosting, multiple support emails in one instance etc.

oops: Fix call to missing create(), only fetch user form once

Reviewed-By: Peter Rotich <peter@osticket.com>

Email aliases

Reviewed-By: Jared Hancock <jared@osticket.com>

files: FileUploadWidget render

Reviewed-By: Jared Hancock <jared@osticket.com>

Add callback filter to standard iteration method to skip deleted items.

Use file id instead of attachment id to unset new
Get new files objects as array

orm: Partially revert 8ab4432f

Reviewed-By: Peter Rotich <peter@osticket.com>

orm: Remove references to the retired slot feature

Reviewed-By: Jared Hancock <jared@osticket.com>

org: Remove users from deleted org.

Reviewed-By: Jared Hancock <jared@osticket.com>

files: Attempt to standardize thread entry attaching

Reviewed-By: Peter Rotich <peter@osticket.com>

oops: Fix manual sort on help topic admin listing page

Reviewed-By: Peter Rotich <peter@osticket.com>

org: Propagate LEFT joins in join paths

Reviewed-By: Peter Rotich <peter@osticket.com>

Credit @Jared

Include username when checking if a system email already exists. This
is important for emails that use aliases.

Use org_id to filter users to update on organization delete

forms: Fix lag updating the CDATA table

Reviewed-By: Peter Rotich <peter@osticket.com>

Config  items cache

If something like members__staff is considered leaving the Team model,
and the `members` relationship is nullable, and the `staff` relationship is
not, in the context of the compiled SQL statement, the second join should
also be considered nullable (LEFT join), because otherwise inconsistent
results would be returned from the query.

In other words, if a count is considered as an annotation to the Team model
instances, Teams with zero members should still be considered as valid teams
and should be selected with such an annotation. Before this patch, however,
the join between TeamMember and Staff would have been an inner join instead
of a LEFT join, which could skew the database results.

This fixes an issue where the CDATA table is updated with the OLD version of
an answer after it is updated. That is, after an answer is updated, the
CDATA table is also updated to reflect the change; however, the old content
of the answer value is used when updating the CDATA value.