- Nov 11, 2019
-
-
Peter Rotich authored
Modify Reopen Assignment
-
- Nov 08, 2019
-
-
Peter Rotich authored
issue: Format File Name
-
aydreeihn authored
This commit modifies the code to ensure that if the 'Disable auto assign on reopen' box is checked for a department, reopened tickets are open as unassigned when a ticket is reopened by a user's message as well as when an agent manually reopens the ticket.
-
- Nov 06, 2019
-
-
Peter Rotich authored
issue: DB Error #1062
-
JediKev authored
This formats the filename before using it in an error to avoid chance of XSS.
-
JediKev authored
This addresses a long-time issue of the famous `DB Error #1062` when uploading an Inline File to a Draft. The issue is that the system does not check if an Attachment record exists before creating a new one. We create a new Attachment record, we go to save it, and the system errors out because that record already exists. This adds a check to see if the Attachment record already exists and if so we use that instead of creating a new one.
-
- Nov 05, 2019
-
-
Peter Rotich authored
Issue: Edit Task Fields
-
Peter Rotich authored
issue: In-Reply-To Header
-
- Nov 04, 2019
-
-
aydreeihn authored
This commit fixes an issue where you were unable to edit custom fields if they were added to a task form after a task had been created.
-
- Nov 01, 2019
-
-
Peter Rotich authored
issue: Delete Org Session Failure
-
JediKev authored
This addresses an issue raised in 5111 where the `in-reply-to` header is not sent with outgoing emails. This is due to the `$recipients` variable being an instance of `MailingList` which is not handled correctly in `class.mailer.php`. This adds a new case to handle `MailingList` directly.
-
- Oct 31, 2019
-
-
Peter Rotich authored
issue: Attachment Filter
-
Peter Rotich authored
issue: Umlauts In Sender's Name
-
Peter Rotich authored
issue: Umlauts In Subject
-
- Oct 30, 2019
-
-
JediKev authored
This addresses an ORM failure where upon refetching an object from the database that no longer exists the system crashes hard. We use the `one()` method which expects one result, if there is no result it throws a `DoesNotExist` exception. We are not catching the exception properly which crashes osTicket and forces you to clear the session via browser or database.
-
JediKev authored
This addresses an issue on the Forum where deleting an Organization causes the session to fail. This is due to the Organization QuerySet being stored in the session and not being cleared out when deleted from the system. This causes the system to try to refetch the object from the database which it's not there as it's been deleted and therefore causes the session to crash.
-
- Oct 29, 2019
-
-
JediKev authored
This addresses issue 5123 where fetched Emails do not reject attachments that are not allowed. This is due to setting a File ID inside of an array called `$file[]` but not unsetting it when the attachment hits an FileUploadError. This updates class MailFetch to set the file array back to empty so that the ID is cleared and the error is added correctly which rejects the attachment.
-
- Oct 28, 2019
-
-
JediKev authored
This addresses an issue where Piping email to osTicket and having Umlauts in the Subject line causes the Subject to be malformed. This is due to the `mimedecode()` method for class Format which is used by the API to transcode the Subject line in emails. This adds a check to see if the `mb_detect_encoding()` method exists so we can detect the value's encoding. If it exists and we can detect the value's encoding the system will transcode the text from the detected encoding to UTF-8. If we cannot detect the encoding the text will continue through the other encoding checks.
-
JediKev authored
This addresses issue 4884 where sending an email with Umlauts in the From Name causes the User's Name and Email to be malformed. This is due to outdated RFC822 from Pear. This replaces the old RFC822 Pear module with the latest release so that we are up to date.
-
- Oct 25, 2019
-
-
Peter Rotich authored
Fix use of possibly uninitialised $_SERVER['HTTPS']
-
Patrik Lermon authored
-
- Oct 24, 2019
-
-
Peter Rotich authored
i18n: KnowledgeBase Category and JS
-
Peter Rotich authored
issue: Spaces In Username
-
JediKev authored
This addresses issue 5122 where having a space at the beginning and/or end of the login Username/Email on the Client Portal the system will return `Access Denied`. This is due to the system not trimming the rogue spaces. This adds `trim()` around the Username/Email so that the spaces are removed and login will be successful.
-
- Oct 23, 2019
-
-
JediKev authored
In 5120, the reporting party also mentioned that they receive an error of `script '/xxx/osTicket/kb/ajax.php' not found or unable to stat`. This is due to the AJAX call being inside the KB directory, and `/kb/ajax.php` truly does not exist. This adds `ROOT_PATH` to the beginning of the AJAX call so that no matter where it is, it will point to the correct location.
-
JediKev authored
This addresses 5120 where main (or Parent) FAQ Category Titles are not translated even though the child Category titles are translated correctly. This is due to to the system pulling the Full Name instead of the Local (translated) Name.
-
- Oct 21, 2019
-
-
Peter Rotich authored
i18n: OpenSSL Error
-
Peter Rotich authored
Make message variable (%{message}) optional
-
- Oct 09, 2019
-
-
JediKev authored
This addresses issue 5095 where installing a Language Pack and visiting the Dashboard > Information page without OpenSSL installed/configured will throw a fatal error of `Call to undefined function openssl_pkey_get_public()`. This is due to no check for the `openssl` extension before the dependant method is called. This adds a check so that if OpenSSL is not available we can return a useful error code of `VERIFY_EXT_MISSING` (which is error code `2`) and continue without disrupting the content.
-
Peter Rotich authored
Make message variable optional for new tickets opened by agents. This is necessary for help topics with issue details disabled.
-
- Oct 08, 2019
-
-
Peter Rotich authored
Datatimepicker: Time format
-
- Oct 07, 2019
-
-
Peter Rotich authored
This commit addresses an issue where time format in 24 hrs resulted in double hours.
-
- Oct 04, 2019
-
-
Peter Rotich authored
issue: Revert fefed147
-
Peter Rotich authored
issue: ACL Oopsie
-
JediKev authored
This addresses an issue where initially saving the ACL will fail. This is due to the incorrect variable being used to lookup the IP in the ACL. This updates the variable from `$acl` to the correct variable `$vars['acl']`.
-
- Oct 02, 2019
-
-
JediKev authored
This addresses issue 5084 by partially reverting commit `fefed147`. In said commit, we updated `THIS_VERSION` to utilize `MAJOR_VERSION` which is fine. However, we also updated the deploy module to copy the same format. This interferes with the osTicket Version check by not including the entire subversion and not starting with a `v` (ie. `v1.12.3`). This reverts the copied format section of the commit so that `THIS_VERSION` will be the full, non-git version when deployed/packaged.
-
Peter Rotich authored
issue: Mbstring Extension Requirement
-
JediKev authored
This addresses an issue reported on the forum where printing a ticket in v1.12 and above requires `mbstring`. This updates the print call to check for the `mbstring` extension and if not loaded will fail with a detailed error `mbstring extension required to print ticket to PDF`.
-
- Oct 01, 2019
-
-
Peter Rotich authored
Instantiate StaffDeptAccess
-