Skip to content
Snippets Groups Projects
  1. Nov 11, 2019
  2. Nov 08, 2019
  3. Nov 06, 2019
    • Peter Rotich's avatar
      Merge pull request #5149 from JediKev/issue/db-error-1062 · cca97eda
      Peter Rotich authored
      issue: DB Error #1062
    • JediKev's avatar
      issue: Format File Name · bd427cdf
      JediKev authored
      This formats the filename before using it in an error to avoid chance of
      XSS.
      bd427cdf
    • JediKev's avatar
      issue: DB Error #1062 · 27c925cc
      JediKev authored
      This addresses a long-time issue of the famous `DB Error #1062` when
      uploading an Inline File to a Draft. The issue is that the system does not
      check if an Attachment record exists before creating a new one. We create a
      new Attachment record, we go to save it, and the system errors out because
      that record already exists. This adds a check to see if the Attachment
      record already exists and if so we use that instead of creating a new one.
      27c925cc
  4. Nov 05, 2019
  5. Nov 04, 2019
    • aydreeihn's avatar
      Issue: Edit Task Fields · 05cbb758
      aydreeihn authored
      This commit fixes an issue where you were unable to edit custom fields if they were added to a task form after a task had been created.
      05cbb758
  6. Nov 01, 2019
  7. Oct 31, 2019
  8. Oct 30, 2019
    • JediKev's avatar
      orm: Refetch Failure · eb4bda84
      JediKev authored
      This addresses an ORM failure where upon refetching an object from the
      database that no longer exists the system crashes hard. We use the `one()`
      method which expects one result, if there is no result it throws a
      `DoesNotExist` exception. We are not catching the exception properly which
      crashes osTicket and forces you to clear the session via browser or
      database.
      eb4bda84
    • JediKev's avatar
      issue: Delete Org Session Failure · bbd0c255
      JediKev authored
      This addresses an issue on the Forum where deleting an Organization causes
      the session to fail. This is due to the Organization QuerySet being stored
      in the session and not being cleared out when deleted from the system. This
      causes the system to try to refetch the object from the database which it's
      not there as it's been deleted and therefore causes the session to crash.
      bbd0c255
  9. Oct 29, 2019
    • JediKev's avatar
      issue: Attachment Filter · 9f4fbc27
      JediKev authored
      This addresses issue 5123 where fetched Emails do not reject attachments
      that are not allowed. This is due to setting a File ID inside of an array
      called `$file[]` but not unsetting it when the attachment hits an
      FileUploadError. This updates class MailFetch to set the file array back to
      empty so that the ID is cleared and the error is added correctly which
      rejects the attachment.
      9f4fbc27
  10. Oct 28, 2019
    • JediKev's avatar
      issue: Umlauts In Subject · cccdb152
      JediKev authored
      This addresses an issue where Piping email to osTicket and having Umlauts in
      the Subject line causes the Subject to be malformed. This is due to the
      `mimedecode()` method for class Format which is used by the API to transcode
      the Subject line in emails. This adds a check to see if the
      `mb_detect_encoding()` method exists so we can detect the value's encoding.
      If it exists and we can detect the value's encoding the system will
      transcode the text from the detected encoding to UTF-8. If we cannot detect
      the encoding the text will continue through the other encoding checks.
      cccdb152
    • JediKev's avatar
      issue: Umlauts In Sender's Name · e3f42c33
      JediKev authored
      This addresses issue 4884 where sending an email with Umlauts in the From
      Name causes the User's Name and Email to be malformed. This is due to
      outdated RFC822 from Pear. This replaces the old RFC822 Pear module with the
      latest release so that we are up to date.
      e3f42c33
  11. Oct 25, 2019
  12. Oct 24, 2019
  13. Oct 23, 2019
    • JediKev's avatar
      i18n: KnowledgeBase JS · bce8296e
      JediKev authored
      In 5120, the reporting party also mentioned that they receive an error of
      `script '/xxx/osTicket/kb/ajax.php' not found or unable to stat`.  This is
      due to the AJAX call being inside the KB directory, and `/kb/ajax.php` truly
      does not exist. This adds `ROOT_PATH` to the beginning of the AJAX call so
      that no matter where it is, it will point to the correct location.
      bce8296e
    • JediKev's avatar
      i18n: KnowledgeBase Category · 5646e7c7
      JediKev authored
      This addresses 5120 where main (or Parent) FAQ Category Titles are not
      translated even though the child Category titles are translated correctly.
      This is due to to the system pulling the Full Name instead of the Local
      (translated) Name.
      5646e7c7
  14. Oct 21, 2019
  15. Oct 09, 2019
    • JediKev's avatar
      i18n: OpenSSL Error · af6f0e92
      JediKev authored
      This addresses issue 5095 where installing a Language Pack and visiting the
      Dashboard > Information page without OpenSSL installed/configured will throw
      a fatal error of `Call to undefined function openssl_pkey_get_public()`.
      This is due to no check for the `openssl` extension before the dependant
      method is called. This adds a check so that if OpenSSL is not available we
      can return a useful error code of `VERIFY_EXT_MISSING` (which is error code
      `2`) and continue without disrupting the content.
      af6f0e92
    • Peter Rotich's avatar
      Message Variable - %{message} · 315c4e7c
      Peter Rotich authored
      Make message variable optional for new tickets opened by agents. This is
      necessary for help topics with issue details disabled.
      315c4e7c
  16. Oct 08, 2019
  17. Oct 07, 2019
  18. Oct 04, 2019
  19. Oct 02, 2019
    • JediKev's avatar
      issue: Revert fefed147 · c9be2e00
      JediKev authored
      This addresses issue 5084 by partially reverting commit `fefed147`. In said
      commit, we updated `THIS_VERSION` to utilize `MAJOR_VERSION` which is fine.
      However, we also updated the deploy module to copy the same format. This
      interferes with the osTicket Version check by not including the entire
      subversion and not starting with a `v` (ie. `v1.12.3`). This reverts the
      copied format section of the commit so that `THIS_VERSION` will be the full,
      non-git version when deployed/packaged.
      c9be2e00
    • JediKev's avatar
      Add Release Notes for v1.12.3 · bcf1a6f1
      JediKev authored
      v1.12.3
      bcf1a6f1
    • Peter Rotich's avatar
      Merge pull request #5079 from JediKev/issue/mbstring-ext-requirement · 2e6d1e55
      Peter Rotich authored
      issue: Mbstring Extension Requirement
    • JediKev's avatar
      issue: Mbstring Extension Requirement · 5a96884d
      JediKev authored
      This addresses an issue reported on the forum where printing a ticket in
      v1.12 and above requires `mbstring`. This updates the print call to check
      for the `mbstring` extension and if not loaded will fail with a detailed
      error `mbstring extension required to print ticket to PDF`.
      5a96884d
  20. Oct 01, 2019
Loading