Skip to content
Snippets Groups Projects
  1. Apr 22, 2019
  2. Apr 16, 2019
  3. Apr 15, 2019
  4. Apr 12, 2019
    • JediKev's avatar
      issue: Choice Validation Accept Punctuation · a01ed2aa
      JediKev authored
      This addresses issue mentioned in 4071 where the choice field validation is
      not accepting punctuations. This updates the regex to accept anything the
      user inputs. This introduces another issue that if the choice contains `:`
      in the value then it will truncate everything after. This is due to the
      explode method that explodes on any `:` character. This updates the explode
      method to return only 2 values which only explodes on one `:` character
      which returns the full value.
      a01ed2aa
  5. Apr 11, 2019
    • JediKev's avatar
      issue: iFrame Single Quotes · ae5ced39
      JediKev authored
      It's all about the single quotes baby! Apparently I can't read; the single
      quotes are only meant for word options such as `'self'` and `'none'`. When
      adding single quotes to the `<host-source>` options it takes them
      literally…too literally. For example, if your options are `'localhost:80
      localhost:8080 localhost:8000'` then `'localhost:80` and `localhost:8000'`
      will be seen as "invalid" due to the single quotes. This removes the single
      quotes from every line that sets the CSP so all options are valid. This also
      adds single quotes around the `self` option so it stays valid as well.
      ae5ced39
  6. Apr 10, 2019
  7. Apr 04, 2019
    • JediKev's avatar
      issue: sendAccessLink On NULL v1.11 · 035eabd5
      JediKev authored
      This addresses an issue in v1.11 where sending an Access Link via email to a
      Collaborator fails with fatal error. This is due to the type of User class
      that is sent to the `Mailer::send()` function. The ClientSession User class
      is not appropriate for this method, rather, TicketOwner or Collaborator User
      classes are appropriate. This adds a function called `getSessionUser()` to
      the ClientSession class so we can retrieve the TicketOwner/Collaborator User
      class from the session.
      035eabd5
    • Peter Rotich's avatar
      Merge pull request #4825 from JediKev/issue/org-ticket-export-no-filename · dcd94b22
      Peter Rotich authored
      issue: Organization Ticket Export No Filename
    • JediKev's avatar
      issue: sendAccessLink On NULL · 6f9f2e17
      JediKev authored
      This addresses an issue where entering a collaborator's email to send ticket
      email access link throws a fatal error. This is due to the method that
      checks for tickets with the User's email equal to the email provided. This
      only checks for User's emails not Collaborator emails. This adds a check for
      Collaborator emails as well so this will not crash out.
      6f9f2e17
  8. Apr 03, 2019
  9. Apr 02, 2019
    • aydreeihn's avatar
      MPDF Issues · 064e0020
      aydreeihn authored
      1. Task Exports: This commit fixes the contructor for printing Tasks using MPDF
      
      2. PDF Formatting: This commit fixes an issue where the header of each thread entry did not stretch across the page correctly. This was an unintentional side effect of trying to fix the way HTML tables printed in PDFs.
      
      3. FAQ PDFs: This commit passes the correct values to mPDFWithLocalImages when printing FAQs
      064e0020
    • JediKev's avatar
      issue: Organization Ticket Export No Filename · 18089165
      JediKev authored
      This addresses an issue where clicking Export on an Organization's Tickets
      will export a file with the filename of 'csv' and no extension. This is due
      to the variables we are passing to the `saveTickets` function. We are
      missing a variable called '$fields' that contains a list of fields.
      18089165
  10. Apr 01, 2019
  11. Mar 29, 2019
  12. Mar 28, 2019
    • JediKev's avatar
      oops: Thread Variable Fatal Error · 97a9aa8d
      JediKev authored
      This addresses an issue introduced with 4737 where using `%{ticket.thread}`
      causes a fatal error. This is because `ObjectThread->asVar()` returns an
      object which cannot be converted to a string. This adds a `__tostring()`
      function to class ThreadEntries so it can be converted to a string properly.
      97a9aa8d
  13. Mar 27, 2019
Loading