Skip to content
Snippets Groups Projects
  1. May 01, 2014
  2. Apr 30, 2014
    • Peter Rotich's avatar
      Merge pull request #825 from greezybacon/issue/tnef-bad-rewind · d4fed2cd
      Peter Rotich authored
      
      tnef: Fix major issue iterating over attar streams
      
      Reviewed-By: default avatarPeter Rotich <peter@osticket.com>
      d4fed2cd
    • Jared Hancock's avatar
      tnef: Fix major issue iterating over attr streams · 34d8d0b4
      Jared Hancock authored
      The original logic would read the count of attributes in the stream and then
      read the first attribute in the constructor of TnefAttributeStreamReader.
      Then the iterator interface would call ::rewind() before iterating to the
      first item. rewind() set the @pos attribute to zero, which would cause the
      attribute count (4-byte int) to be interpreted incorrectly as part of the
      first attribute.
      
      The new logic sets the position at 4 after rewind()ing, and does not read
      the first attribute twice. It also properly detects the end of the attribute
      stream by the number of attributes advertised as the first four bytes of the
      stream (read into the @count attribute initially).
      34d8d0b4
  3. Apr 29, 2014
  4. Apr 28, 2014
  5. Apr 25, 2014
  6. Apr 24, 2014
  7. Apr 23, 2014
  8. Apr 18, 2014
  9. Apr 16, 2014
  10. Apr 15, 2014
  11. Apr 14, 2014
    • Jared Hancock's avatar
      Fixup merging of email recipients · 0c32eabb
      Jared Hancock authored
      This stems from a confusing similarity between the + operator for arrays
      and array_merge() in php. Adding arrays will ignore items in the RHS where
      keys are present in the LHS. Therefore, when adding numerically indexed
      arrays together, only items on the RHS that have a key higher than the
      greatest key on the LHS will be included.
      0c32eabb
    • Jared Hancock's avatar
      f40c018d
    • Jared Hancock's avatar
      Relax detection of images for strip detection · f8b490d0
      Jared Hancock authored
      It is perfectectly fine to have an image cited in an HTML body similar to:
      
      <img width=909 height=302 src=cid:image002.jpg@01CF5426.BF5A72A0 alt=image>
      
      Which may or may not have quoted @src attribute, and may very well have an
      at sign (@) somewhere in the attribute text. The previous regular expression
      would not match such a @src attribute.
      f8b490d0
    • Peter Rotich's avatar
      Merge pull request #779 from greezybacon/issue/inline-img-missing-cid · 6b753cac
      Peter Rotich authored
      
      Inline images in email without a 'cid:' indicator
      
      Reviewed-By: default avatarPeter Rotich <peter@osticket.com>
      6b753cac
    • Jared Hancock's avatar
      Inline images in email without a 'cid:' indicator · 3c3ffbfa
      Jared Hancock authored
      It is the defacto standard to reference an inline image in an email by
      referencing the Content-ID header of the referenced attachment in the @src
      attribute of the image. For instance, `<imc src="cid:image001.png">` where
      the `cid:` scheme of the attribute indicates that the referenced image URL
      is a separate content of the email. The image attached to the email would
      have an accompanying header like: `Content-Id: <image001.png>`. However,
      some mail systems, including a certain fax to email service, do not
      correctly indicate the location of the image with the content-id URL.
      Instead, the referenced image tag would be `<img src="image001.png">`
      
      This patch addresses the issue by searching the message body for all
      references to attached content-id's in all @src attributes with or without
      the content-id URL scheme indicator. Previously, such images would not be
      displayed inline in the ticket thread.
      
      References:
      https://tools.ietf.org/html/rfc2392
      3c3ffbfa
    • Jared Hancock's avatar
      345788a9
  12. Apr 11, 2014
  13. Apr 08, 2014
  14. Apr 04, 2014
  15. Apr 02, 2014
  16. Apr 01, 2014
Loading