User::fromVars in class ticket was the root. Eventually, in
DynamicForm::getDynamicFields(), isset($this->id) was used to detect
unsaved, new forms that have not been committed to the database; however,
the isset() method was not implemented for the ORM.

Use Unix style line-endings for Windoze mail()

Reviewed-By: Peter Rotich <peter@osticket.com>

Rewrites Mail_Parse::parsePriority function

Reviewed-By: Peter & Jared 

signals: pass variable by reference

Reviewed-By: Peter & Jared

Fix various XSS vulnerabilities

Reviewed-By: Peter Rotich <peter@osticket.com>

In both the client and staff interfaces, where the URL and request
parameters were echo'd back without any escaping

Partially revert 37b8d549

Reviewed-By: Peter Rotich <peter@osticket.com>

forms: Fix corruption of company name on new ticket

Reviewed-By: Peter Rotich <peter@osticket.com>

That patch introduced a bug where the list of dynamic fields for a form is
always empty

New ticket by staff would cause the %{company.name} variable to be
incorrectly replaced as the user's name in email templates.

Correctly generate ticket_link for message confirm

Reviewed-By: Peter Rotich <peter@osticket.com>

forms: Ensure the issue summary will have data

Reviewed-By: Peter Rotich <peter@osticket.com>

Otherwise, no column will be added to the %ticket__cdata table and the
ticket queue pages will be crashed (empty).

user: Fix variable replacement for %{ticket.user}

Reviewed-By: Peter Rotich <peter@osticket.com>

Update class.mailparse.php function splitHeaders

Reviewed-By: Peter Rotich & Jared 

Instead, previously, a maxlength of zero effectively disabled the field,
because it prevented any user input into the field.

function splitHeaders updated in order to correctly parse mail header lines
starting with tabs

pipe: Decode address lists names after parsing emails

Reviewed-By: Peter Rotich <peter@osticket.com>

Otherwise, if a decoded email name has a comma in it, for instance

From: =?utf-8?B?RnJ5ZGVubHVuZCBIeW3DuGxsZXIsIEJldHRpbmE=?=
    <bettina.frydenlundhymoller@domain.com>

The address list will be parsed incorrectly since the comma has an ambiguous
significance. Usually, the personal name would be quoted; however, since it
is encoded, there is no need to quote it.

Fix munging of linked external images

Reviewed-By: Peter Rotich <peter@osticket.com>

Previously, the display of the button was incorrect and more than one button
might have been displayed.

htmLawed stripped/discarded <div> tags nested inside inline tags such as
<a>. The previous replacement engine would replace <img> tags with <div>
tags and would cause the HTML to be corrupted by htmLawed.

This patch uses <span> tags which have CSS rules to be displayed as
inline-blocks. This should stay truer to the normal sizing and placement of
the original <img> tag.

And use admin-defined site logo

forms: Fixup misleading page after save

Reviewed-By: Peter Rotich <peter@osticket.com>