Skip to content
Snippets Groups Projects
  1. May 15, 2018
    • JediKev's avatar
      issue: Prevent Click Jacking · 8c3f7a5f
      JediKev authored
      This addresses a vulnerability where there was no `X-Frame-Options` header
      which could potentially allow click jacking. This adds the
      `X-Frame-Options: SAMEORIGIN` header so it will remove any chance of click
      jacking. According to Mozilla Developer Docs:
      ```
      SAMEORIGIN
      The page can only be displayed in a frame on the same origin as the page
      itself.
      ```
      8c3f7a5f
    • JediKev's avatar
      issue: Information Page Performance · 5b5e8c98
      JediKev authored
      This addresses an issue on the forums where the query to determine the
      size of the `file_chunk` table is making the page load really slow for
      people with large tables. This updates the query to improve the
      performance of the page load time.
      5b5e8c98
    • JediKev's avatar
      issue: Files - deleteOrphans() · b05dcbda
      JediKev authored
      This addresses the issue where files were being deleted before being sent
      out in Agent responses. This was due to a bug in the query that gets the
      orphaned files. This query was getting files created within the last 24
      hours not after the last 24 hours. The query also had another bug that
      would use the time from PHP instead of MySQL which could cause issues.
      This updates the query as per @greezybacon's suggestions to delete
      orphaned files that were created more than 24 hours ago.
      b05dcbda
    • JediKev's avatar
      issue: Outlook _MailEndCompose · faea6346
      JediKev authored
      This addresses an issue where Outlook adds weird (and seemingly random)
      _MailEndCompose tags to the email body which turns unwanted content into
      links. This adds the _MailEndCompose tag to Format::sanitize() so it
      will be removed from the email body.
      faea6346
    • JediKev's avatar
      upgrader: Flush Cache On Upgrade · c3f5904b
      JediKev authored
      This addresses an issue where the Upgrader will sometimes use an outdated
      cached object and throw an error. This adds a the function to clear the
      Model Cache every time the Upgrader runs an Upgrade Patch to get fresh
      objects.
      c3f5904b
    • JediKev's avatar
      issue: Org. User Account Status · d3beb9e8
      JediKev authored
      This addresses an issue where the User’s account status is always 'Active'
      in the Organization list no matter what their actual status is. This adds the
      account status to the user query which adds the correct status to the Users’
      account.
      d3beb9e8
  2. Mar 22, 2018
  3. Mar 20, 2018
  4. Mar 06, 2018
    • JediKev's avatar
      xss: Prevent Agent Directory XSS · 36651b91
      JediKev authored
      This addresses a vulnerability where an Agent can perform XSS via the
      Agent Directory’s REQUEST query string. This sanitizes the request params
      so the code will be escaped and not executed in the browser.
      36651b91
  5. Feb 21, 2018
    • JediKev's avatar
      oops: Fix randNumber() · 5b8b95ab
      JediKev authored
      This addresses an issue where the `randNumber()` function would crash on
      32-Bit systems if the ticket format was set to a really high amount of
      digits (eg. ###################). This is because the `max()` value that
      was being passed to `mt_rand()` exceeded the `mt_getrandmax()` limit which
      caused an error. This updates the function to generate a random number for
      each digit to avoid the `mt_getrandmax()` limit.
      5b8b95ab
  6. Feb 12, 2018
    • JediKev's avatar
      oops: Prevent Account Takeover · be0133b0
      JediKev authored
      This addresses an issue where someone can “takeover” an account with only
      a User’s email and a User’s previous ticket number. Once they get access
      to a User’s ticket they can go to the Ticket Owner’s profile and change
      the email to whatever they’d like. This adds a check on the profile to see
      if the User is a Guest User. If they are a Guest then it kicks them back
      to the ticket view. If they are the actual User it will let them view the
      profile.
      be0133b0
  7. Feb 07, 2018
  8. Nov 06, 2017
    • JediKev's avatar
      issue: File Upload Bypass · 3eb16147
      JediKev authored
      This addresses an issue where someone can bypass the file restrictions on
      the file upload field in the Client Portal. This adds the allowed
      extensions and file types to the field options so that User’s cannot
      upload anything other than the allowed file types.
      3eb16147
  9. Oct 19, 2017
    • JediKev's avatar
      issue: Httponly Cookies · 5b2dfce9
      JediKev authored
      This addresses issue 4015 where osTicket’s cookies aren’t HttpOnly by
      default. The HttpOnly flag helps prevent client scripts accessing the
      cookie. This updates the method that sets the cookie params to include
      the HttpOnly flag.
      5b2dfce9
  10. Sep 28, 2017
  11. Sep 23, 2017
  12. Sep 14, 2017
  13. Aug 15, 2017
  14. Aug 10, 2017
  15. Aug 08, 2017
    • JediKev's avatar
      tasks: Fix Task Updated Time · d6dfa7a6
      JediKev authored
      This addresses an issue where updating a Task does not change the
      `updated` column in the database. This adds a line to change the `update`
      column when updating a Task.
      d6dfa7a6
Loading