- Mar 27, 2019
-
-
Peter Rotich authored
Issue: Saving Checkbox Values
-
aydreeihn authored
Issue: Duplicate Tickets in Closed Queue
-
aydreeihn authored
This commit fixes an issue where checkboxes could not be edited for inline edit or all field edits. When a BooleanField is directly passed to the to_database method, you are not able to accurately check to see if old != new. To fix this, I added a new getChanges method to the BooleanField class that will first do a comparison on the raw boolean value (true, false) and then get the value needed for the database. I then made sure that we use that new function when editing all fields together. Additionally, I added a getClean method to the BooleanField class so that $this->_clean for the field would be set to either true or NULL depending on if the box is checked or not and would accurately save to the database when calling $form->saveAnswers()
-
- Mar 26, 2019
-
-
Peter Rotich authored
Assignment Restriction Issue
-
aydreeihn authored
This commit fixes an issue where we were not checking the restrictions on Ticket assignment correctly. isAccessLimited returns true if showAssignedOnly is true, so we wouldn't want to negate the isAccessLimited check (that would return true if access is not limited). Also, if an Agent's access is limited to assigned tickets only, we can return the assigned tickets once we have them without needing to go through any further processing. Finally, we should still allow an agent to view an assigned ticket even if the ticket is closed. Note: queue counts update themselves a little after you toggle the 'Limit ticket access to ONLY assigned tickets' check box. The 'See all tickets in search results, regardless of access' still works correctly as well.
-
Peter Rotich authored
Quick Filter Fixes:
-
aydreeihn authored
Make the following work: - Assigned - Assignee - Department Manager - Assigned Team Also, make sure we account for if there are no choices available for a quick filter Ex: The helpdesk does not have any teams
-
Peter Rotich authored
issue: APC CLI
-
Peter Rotich authored
Issue: MPDF Export PHP < 7.0
-
aydreeihn authored
This commit fixes an issue where using MPDF to print Tickets did not work if the PHP version was < 7.0 because MPDF called the random_int function which is only available for PHP 7.0+. Now, we check the PHP version before printing, and if it is less than 7.0, we use the rand function. If it is >= 7.0, we continue to use the random_int function.
-
Peter Rotich authored
issue: Multilingual FAQ Category w/ Parent
-
Peter Rotich authored
issue: Task Print PDF
-
- Mar 22, 2019
-
-
JediKev authored
This addresses an issue where clicking print on a Task throws a fatal error. This is due to the Task2PDF function passing a string instead of an array to `Mpdf::__construct()`. The `__construct()` of class Mpdf requires an array of configurations so we are now passing an array instead of a string.
-
- Mar 21, 2019
-
-
JediKev authored
This addresses issue 4810 where having more than one language installed and trying to add a new FAQ Category with a Parent Category relation fails to add the Parent Category relation. This is due to multiple Select2 fields; the POST data includes only the last Select2 field's value instead of the one in the tab you're currently on. This adds a script to set all Select2 fields in all the available languages to the same value so the POST will always contain the appropriate Parent ID no matter what language tab you’re on.
-
- Mar 12, 2019
-
-
Peter Rotich authored
-
Peter Rotich authored
-
Peter Rotich authored
Queue Columns
-
Peter Rotich authored
issue: Duplicate Form Titles
-
Peter Rotich authored
Issue: PDF printout
-
aydreeihn authored
This commit fixes 2 issues we had with using MPDF to export Tickets: 1. Tickets with inline images To refer to images as var:varname, imageVars needs to be set for the MPDF object. 2. Tickets with tables When exporting a Ticket where a Thread Entry contains a table, we must ignore table percents and table widths, otherwise, it will always throw the error "Word is too long to fit in table"
-
- Mar 11, 2019
-
-
JediKev authored
This addresses an issue mentioned in the forum where having more than one custom field on a ticket shows the same title for all forms on the client-side ticket view (after creation). This adds an array of the form names indexed by sort order and displays them in the correct order with the correct names.
-
- Mar 09, 2019
-
-
Peter Rotich authored
Allow admin to setup columns when creating a new parent queue and address an issue where Assignee standard columns used a wrong Id.
-
- Mar 08, 2019
-
-
Peter Rotich authored
-
Peter Rotich authored
-
- Mar 06, 2019
-
-
Peter Rotich authored
issue: FAQ Return Errors
-
Peter Rotich authored
Update settings.email.yaml
-
- Mar 05, 2019
-
-
Steve authored
Pop up message hyperlink incorrect with changes made by implementing osTicket docs
-
- Mar 04, 2019
-
-
JediKev authored
This addresses an issue reported on the Forum where creating a new FAQ and not filling out required information returns the correct error but returns the incorrect template (FAQ View Template). This is due to the check for an FAQ when determining the template to return. This adds a check for the FAQ ID to determine if it’s an actual FAQ or just a model instance.
-
Peter Rotich authored
issue: FAQ Search Results
-
Peter Rotich authored
issue: Canned Response Variables
-
JediKev authored
This addresses an issue reported on the forum where searching for a keyword in FAQ search brings back more results than it should. This is due to the format of the query selecting the results, essentially, the `WHERE NOT` statement is not properly formatted so the `OR` statements take precedence over the `WHERE NOT` causing non-public results to be shown to the client. The `WHERE NOT` statement contains the bit to select from only public faqs and since the `OR` takes precedence it will return the non-public results too.
-
- Feb 27, 2019
-
-
Peter Rotich authored
issue: PHP 7.2 Ticket Status
-
- Feb 26, 2019
-
-
JediKev authored
This addresses issue 4756 where the `%{recipient.ticket_link}` variable is not being replaced when the canned response is loaded in the reply box; all other link variables work. This is due to the recipient object not being passed to the variableReplacer which means the ticket_link is not available. This adds the recipient object to the variableReplacer so the ticket_link variable is properly replaced like the others on load.
-
JediKev authored
This addresses issue 4716 where updating a Ticket Status throws a fatal error of "Too few arguments" when using PHP 7.2. This is due to `$errors` not being passed to the `update()` function causing PHP 7.2 to freak out. This creates an `$errors` array and passes it to `update()` so PHP 7.2 is happy and we are all happy. :)
-
Peter Rotich authored
issue: Internal Note Ignored
-
- Feb 25, 2019
-
-
JediKev authored
This addresses issue 4743 where the system ignores Internal Notes on Ticket Creation. This is due to the ticket being assigned and not having the Internal Note passed along.
-
Peter Rotich authored
Minor typo fix
-
Peter Rotich authored
issue: Custom Column Org Link
-
- Feb 22, 2019
-
-
JediKev authored
This addresses issue 4579 where setting a Custom Column to User Organization and choosing the User Org Link filter the system shows the wrong link to the Org. This is due to "scp/" not being added to the URL therefore showing an invalid link.
-
- Feb 21, 2019
-
-
Sebastian Haderecker authored
-