issue: Attachment Filter

issue: Umlauts In Sender's Name

issue: Umlauts In Subject

This addresses issue 5123 where fetched Emails do not reject attachments
that are not allowed. This is due to setting a File ID inside of an array
called `$file[]` but not unsetting it when the attachment hits an
FileUploadError. This updates class MailFetch to set the file array back to
empty so that the ID is cleared and the error is added correctly which
rejects the attachment.

This addresses an issue where Piping email to osTicket and having Umlauts in
the Subject line causes the Subject to be malformed. This is due to the
`mimedecode()` method for class Format which is used by the API to transcode
the Subject line in emails. This adds a check to see if the
`mb_detect_encoding()` method exists so we can detect the value's encoding.
If it exists and we can detect the value's encoding the system will
transcode the text from the detected encoding to UTF-8. If we cannot detect
the encoding the text will continue through the other encoding checks.

This addresses issue 4884 where sending an email with Umlauts in the From
Name causes the User's Name and Email to be malformed. This is due to
outdated RFC822 from Pear. This replaces the old RFC822 Pear module with the
latest release so that we are up to date.

Fix use of possibly uninitialised $_SERVER['HTTPS']

i18n: KnowledgeBase Category and JS

issue: Spaces In Username

This addresses issue 5122 where having a space at the beginning and/or end
of the login Username/Email on the Client Portal the system will return
`Access Denied`. This is due to the system not trimming the rogue spaces.
This adds `trim()` around the Username/Email so that the spaces are removed
and login will be successful.

In 5120, the reporting party also mentioned that they receive an error of
`script '/xxx/osTicket/kb/ajax.php' not found or unable to stat`.  This is
due to the AJAX call being inside the KB directory, and `/kb/ajax.php` truly
does not exist. This adds `ROOT_PATH` to the beginning of the AJAX call so
that no matter where it is, it will point to the correct location.

This addresses 5120 where main (or Parent) FAQ Category Titles are not
translated even though the child Category titles are translated correctly.
This is due to to the system pulling the Full Name instead of the Local
(translated) Name.

i18n: OpenSSL Error

Make message variable (%{message}) optional

This addresses issue 5095 where installing a Language Pack and visiting the
Dashboard > Information page without OpenSSL installed/configured will throw
a fatal error of `Call to undefined function openssl_pkey_get_public()`.
This is due to no check for the `openssl` extension before the dependant
method is called. This adds a check so that if OpenSSL is not available we
can return a useful error code of `VERIFY_EXT_MISSING` (which is error code
`2`) and continue without disrupting the content.

Make message variable optional for new tickets opened by agents. This is
necessary for help topics with issue details disabled.

Datatimepicker: Time format

This commit addresses an issue where time format in 24 hrs resulted in
double hours.

issue: Revert  fefed147

issue: ACL Oopsie

This addresses an issue where initially saving the ACL will fail. This is
due to the incorrect variable being used to lookup the IP in the ACL. This
updates the variable from `$acl` to the correct variable `$vars['acl']`.

This addresses issue 5084 by partially reverting commit `fefed147`. In said
commit, we updated `THIS_VERSION` to utilize `MAJOR_VERSION` which is fine.
However, we also updated the deploy module to copy the same format. This
interferes with the osTicket Version check by not including the entire
subversion and not starting with a `v` (ie. `v1.12.3`). This reverts the
copied format section of the commit so that `THIS_VERSION` will be the full,
non-git version when deployed/packaged.

issue: Mbstring Extension Requirement

This addresses an issue reported on the forum where printing a ticket in
v1.12 and above requires `mbstring`. This updates the print call to check
for the `mbstring` extension and if not loaded will fail with a detailed
error `mbstring extension required to print ticket to PDF`.

Instantiate  StaffDeptAccess

Datetime Formats

This commit addresses two issues related to date / time format.

* 24 hrs format, when selected, is now used system-wide even on thread items
* PHP-to-JS date / time format translation is now down in the backend

issue: Revert 453e8152

issue: Complete Thread Var Padding (Outlook)

This addresses issue 5007 where when using the complete thread variable
there is no padding between thread messages in Outlook desktop app and makes
the thread hard to follow. Outlook does not respect some CSS rules that are
accepted in most (if not all) modern email clients. Since we can’t use
normal CSS the workaround is to add a blank table row (with a single space)
so that it forces "padding" between the end of a message and the start of
another.

Before
(image)

After
(image)

This addresses an issue where upgrading from v1.6 to a release on or after
v1.12 will hang on login and eventually timeout. This is due to the system
not being able to fetch the config which logs a db error which calls the
config and continues the loop. For now, we need the config in the
constructor so that the loop doesn't occur and we can continue to upgrade as
normal.

TODO:
- For a permanent fix, we need to figure out why the loop occurs when not in
the constructor and vice versa.

issue: PHP 7.3 New Agent Set Password

Issue: Empty Due Date

This commit fixes an issue that allowed Agents to clear the Duedate on a ticket using inline edit. We were saving the value 0000-00-00 00:00:00 to the database which the ticket would then display as 12/1/02 06:09 pm.

Instead, if an Agent clears the Duedate field, we should save the duedate as null and the ticket should continue using the est_duedate.

This addresses an issue reported on the Forum where creating a new Agent and
setting a password hangs when using PHP 7.3. This is due to too few
arguments passed to `PasswordPolicy::checkPassword()`. This updates the call
to include a second argument of `null` so the method is satisfied and we can
continue with checking the password.

Revert "issue: Advanced Search Default Sorting"

This partially reverts commit dda483eb.
Forcing created by sort resulted in queue columns based sorting getting
overridden.