Within this commit, several files got updated to split up strings like "Disable for this team" / "Disable for this department" into "Disable for" and "this team"/"this department".
So a) a little bit less translations and b) all strings of "this (ticket|task|API|canned|FAQ|depart|email|group|site|SLA|agent|team|template|help|ban|category|custom|end user|role)" can match already existing "this ..." translations now.
PS: Didn't remove all that whitespaces in include/staff/tpl.inc.php - seems like my php editor app has done that automatically :/

Note: Since I'm not sure if that's all (replacing %s %s with %1$s %2$s) which is necessary to make this work, I'm sorry in advance for a potential "bad commit".

As already written on Crowdin, in German the order is wrong, so my suggestion is to make it possible to change the order by transforming "%s %s" to "%1$s and %2$s".
Format in English: Successfully assigned 4 selected tasks
Needed German: Successfully 4 selected tasks assigned

forms: Fix lag updating the CDATA table

Reviewed-By: Peter Rotich <peter@osticket.com>

Config  items cache

Looks like someone forgot to transform this here so it can be translated

Looks like the notes are missing (forgotten?) here. Used/Copied the notes from task.transfer.alert.yaml and replaced "task" with "ticket".

Looks like some copy&paste issue, replaced "ticket" with "task".

Too much splitting here... just realized it when I looked at Crowdin that the German translations sounds like a Google Translation - so basically ok, but obviously wrong.
Reason is that you often don't know what %s stands for and here %s was splitted up into another string with antoher %s which is definitely too much for good :/

This fixes an issue where the CDATA table is updated with the OLD version of
an answer after it is updated. That is, after an answer is updated, the
CDATA table is also updated to reflect the change; however, the old content
of the answer value is used when updating the CDATA value.

Fix translation so it makes sense.
Before: "Unable to change status for 2 any of the selected tickets" - sounds wired
After: "Unable to change status of 2 selected tickets" - sounds correct and fits into the rest of the translation scheme ;)

One s too much here - it's singular and not plural when editing a task

Missing ":" and h2 / h3 was mixed at "Prerequisites", I guess it shall be h3 here

Missing h in highly

If I'm not mistaken this should be equivalent to "Ticket Updated", but it seems here the "d" at the end is missing - so the correct string I think is "Task Updated"!
https://github.com/osTicket/osTicket/blob/develop/include/class.task.php#L1235
https://github.com/osTicket/osTicket/blob/develop/include/class.ticket.php#L2828

Missing m in department

Small typo

Hi Jared @greezybacon,

while translating the new version we from the core of the german translation team (@mfelber and I) ran across several issues with some strings and we opened a lot of issues over at Crowdin, but I think the better way is to propose several PRs here at Github for all the issues (or a large PR with all the issues and a commit for each issue, so you can cherrypick commits).

Before opening all those PRs / one large PR, I just like to know what's the best way to do so (which branch to be used - develop? develop-next?, what type of PR - large PR with several commits? several PRs for each issue? and so on) or if you prefer to look at the issues over at Crowdin and we shall continue opening them there?

The changes within this PR are suggesting to remove the extra "REOPEN %s" and "CLOSE %s" translations since it's really hard to understand what you really translate / in which context you translate here - especially when NOT looking at the source code. Since most translators in my opinion will translate the 3 current strings:
 - Are you sure you want to %s
- CLOSE %s
- selected task / selected tasks
in another way as they would translate the suggestion within this PR:
- Are you sure you want to CLOSE %s
- selected task / selected tasks
I think it'd make sense to change it.

Would be great if you could advise on how to proceed with this and all the other issues we already opened at Crowdin.

Thanks in advance!

Cheers
Michael

Make config items caching class instance based.

forms: Fix attachment security merge conflict

Somehow the attachment security checks got duplicated and messed up. Perhaps
it was a bad merge?

orm: Properly quote objects in queries

Date Time Conversion Mojo

Reviewed-By: Jared Hancock <jared@osticket.com>

This fixes a regression in 4f8f236d, where
the parameters are sent in the SQL statement to the database. Objects which
are converted to a string must be propertly quoted when placed in the query.

ORM queries avoiding caching

Reviewed-By: Peter Rotich <peter@osticket.com>

Add year to php to Date Picker (js) translation table

Make sure due date time dropdown display matches the option value.

Stop doing double timezone offset

Simplified executor which uses the mysqli_query() function to process
queries. This method is faster on MySQL as it doesn't require the PREPARE
overhead, nor require two trips to the database per query. All parameters
are escaped and placed directly into the SQL statement.

This executor extends the traditional mysqli_fetch_xxx() methods by casting
non-null numeric field values to PHP numeric types.