Previously, the code would scan the email headers until it found a positive
match from any of the email headers scanned. Additionally, it would attempt
to find the user from the tagged email references header. However, this
algorithm assumed that the references header was constant and predictable in
its ordering. Recent tests with Gmail prove otherwise in some tests.

This patch changes the system so that only the tagged reference header is
included in the References header, and it will scan all items in a header
(namely the References header) until both the thread and a user are
identified. If a user can be identified, the thread and user are returned.
Otherwise, the first thread hit is returned.

forms: Fix html rendering of checkbox description

Reviewed-By: Peter Rotich <peter@osticket.com>

forms: Always attempt to look up selection value by name

Reviewed-By: Peter Rotich <peter@osticket.com>

api: Handle ArrayObject like an array for request validation

Reviewed-By: Peter Rotich <peter@osticket.com>

Fix incorrect collaborator and owner email links

Reviewed-By: Peter Rotich <peter@osticket.com>

Also, fix duplicate emails where a user as a collaborator would be sent a
confirmation for their own respective email.

forms: Add all forms to the filter subsystem

Reviewed-By: Peter Rotich <peter@osticket.com>

html: Fix dropped text after inserted image

Reviewed-By: Peter Rotich <peter@osticket.com>

email: Always include a message-id token

Reviewed-By: Peter Rotich <peter@osticket.com>

auth: Always show agent login link

Reviewed-By: Peter Rotich <peter@osticket.com>

oops: Swapped last-message and original message

Reviewed-By: Peter Rotich <peter@osticket.com>

Double scp in link: scp/scp/slas.php

Reviewed-By: Jared Hancock <jared@osticket.com>

Make sure ticket create date is used on export

Reviewed-By: Jared Hancock <jared@osticket.com>

On some setups, IE v10 on Windows 7 at least, text added to the Redactor
editor after an image is inserted (via the image popup dialog for instance),
will not be retrieved via the ::get() method and so will not be submitted
with the form submit button.

This patch introduces a workaround by manually calling ::sync() for the
Redactor when the submit button is pressed — just before the form is
submitted.

Turns out the canned response selections for the original message and the
last message were swapped.

Previously, if the quoted response mechanism was disabled, then outgoing
mail would also not include the message-id token. This breaks the
correlation of email to ticket-thread. Now, the message-id token is always
embedded in HTML emails even if the quoted-response removal system is
disabled.

(Turns out that the message-id token was always included in text bodies.)

Previously, if the enduser registration mode were set to something other
than `public`, the agent sign-in link would not be shown. Now, the agent
sign-in link is always shown on the enduser sign-in page.

Thanks for the hint Peter.
Changed it (again) and also tested at our system. /scp/slas.php works as intended - so only the slash "/" before "scp/slas.php" was missing.

Hey again,

just found some other wrong links while I was creating a new ticket filter.

Cheers,
Michael

Hi guys,

here is a catch from the forum: http://osticket.com/forum/discussion/78661/invalid-sla-link-on-popup-help-tips

Since scp/ seems automatically added before slas.php just changed
scp/slas.php to slas.php

Quickly tested it and link works correctly after that little change.

oops: Fix incorrectly placed header line

Reviewed-By: Peter Rotich <peter@osticket.com>

Fix XSS Vulnerability In "tpl.inc.php"

Reviewed-By: Peter Rotich <peter@osticket.com>

oops: Allow filter to set help topic

Reviewed-By: Peter Rotich <peter@osticket.com>

Handle Macintosh style line endings for CSV import

Reviewed-By: Peter Rotich <peter@osticket.com>

Fix applied to where the value is directly output to browser instead of where fetched in case special chars are allowed in `code_name`, which may break logic prior to output.