Skip to content
Snippets Groups Projects
  1. May 20, 2015
  2. Apr 21, 2015
  3. Apr 15, 2015
    • Jared Hancock's avatar
      custom-data: Address major confusion · 4efef017
      Jared Hancock authored
      This feature addresses a major issue with the initial implementation of the
      custom data system. The original system confused the usage of
      database-backed field (dynamic-fields) and their corresponding
      implementation. This created the need to crate awkward caching pieces to
      ensure that validation errors and data was maintained. Furthermore, the
      system confused the linking between form instances (dynamic-entry) and the
      form used to represent that entry.
      
      This patch addresses the confusion in two ways:
      
      Dynamic form entries do not link directly to the dynamic form. Instead, the
      ::getForm() method returns something from the forms API directly.
      Furthermore, the ::getFields() method does not return dynamic field
      instances (database backed / designed fields). Instead, the actual
      implementation of the fields from the forms API is retrieved. This allows
      the fields to *always* be cached, which helps preserve data and validation
      state.
      
      Secondly, the dynamic form uses the same system, so that requests to turn a
      dynamic form into a form (via ::getForm) will also result in the same
      behavior, again, where the fields are represented as forms API fields rather
      than the dynamic fields.
      
      So going forward, the dynamic fields are *only* used to create corresponding
      forms API field implementations. The are associated with the dynamic
      counterparts as sparingly as possible.
      4efef017
  4. Mar 03, 2015
  5. Mar 02, 2015
  6. Dec 13, 2014
    • Jared Hancock's avatar
      upgrade: Fix several crashes upgrading · 505257a9
      Jared Hancock authored
      Handle missing `intl` module
      Handle crash translating the staff login banner, when the %translation table
          does not yet exist
      Handle `allow_client_updates` never having been configured
      Handle staff login without @lang and @extra attributes in database
      505257a9
  7. Dec 12, 2014
  8. Dec 11, 2014
    • Jared Hancock's avatar
      files: Record undetected inline images on upgrade · e8d10846
      Jared Hancock authored
      This will look through the database and find images which appear to be
      inlined in thread entries, but are not recorded as inline. It will update
      the %ticket_attachment table to reflect the inline disposition of the
      images.
      e8d10846
  9. Dec 10, 2014
  10. Dec 08, 2014
Loading