Skip to content
Snippets Groups Projects
  1. Jul 03, 2013
  2. Jun 20, 2012
    • Jared Hancock's avatar
      Implement simple CSRF protection scheme · ff1d8b9e
      Jared Hancock authored
      Protect againts cross-site request forgery attacks by requiring a special
      form-field or header to be sent with requests that modify ticket system
      data.
      
      This meant a slight change to the AJAX ticket locking mechanism. It was
      defined to lock with a GET request; however, GET requests are defined as
      safe methods and should not modify backend data (such as a lock
      acquisition). Therefore, the the lock acquire AJAX method was changed to
      require a POST method.
      
      Also remove old, no-longer-used staff panel include files
      ff1d8b9e
  3. Apr 21, 2012
    • Jared Hancock's avatar
      Add lint test for (calls to) undefined functions · cd4b4faa
      Jared Hancock authored
      And correct several undefined function errors from several source files. So
      while function names in PHP are considered case-insensitive, it still makes
      sense to use consistent camel casing for both defining and calling methods.
      The lint test searches the code base for method calls, and then searches the
      code base again looking for a function definition matching the name of the
      function invoked. It's not failsafe, because it doesn't detect the class
      from which the method should belong, so it's likely to have false negatives.
      Furthermore, it won't work well for PHP 5 where several classes are built
      into PHP (and aren't searchable in the osTicket code base).
      
      Remove the include/staff/api.inc.php as it no longer appears to be used (and
      contains references to undefined methods).
      cd4b4faa
  4. Mar 19, 2012
Loading