Skip to content
Snippets Groups Projects
  1. Mar 22, 2018
    • Peter Rotich's avatar
      Make FAQ & Pages Attachments Viewable · cefe6848
      Peter Rotich authored
      Commit c4579277 introduced an extra administrative security feature to
      restrict files access to signed in users only, even  if a user has a valid
      & signed download URL. The feature, however, did not take into account
      public images & files associated with FAQs and pages such as
      landing/thank-you pages.
      
      This commit addresses the shortcoming by adding a reference ID (attachment ID)
      to the download/access URL, that can be used to deduce the model/object type
      that the file request is associated with. The technique will allow us in the
      future to enforce ACL at the file level depending on privacy settings and
      the security clearance of the user (agent).
      cefe6848
  2. Jun 29, 2017
    • JediKev's avatar
      pages: User Login Page Translation · be06d546
      JediKev authored
      This addresses issue #3860 where if you add a translation to the Login
      Page and view the page in the translated language, the translation does
      not show. This adds the correct method to get the translated page.
      be06d546
  3. Oct 24, 2016
  4. Jun 14, 2016
  5. Jun 03, 2016
    • Michael's avatar
      Internal error occurred #1 · 5e61238f
      Michael authored
      Update two phrases with from "Internal error - Try again!" to "Internal error occurred - Try again!" since it's the most common phrase
      5e61238f
  6. May 09, 2016
  7. Mar 25, 2016
  8. Mar 24, 2016
  9. Mar 18, 2016
    • Jared Hancock's avatar
      orm: Migrate create functionality to the constructor · 1ba40e35
      Jared Hancock authored
      Previously, the create method was used to create a new instance of an orm
      model (which would later result in an INSERT when persisted); however, some
      classes require or utilize varying parameters to their create() method,
      which PHP7 considers an error. Methods in subclasses must be defined with a
      calling signature compatible with the parent class.
      
      This patch shifts the concept of model creation to the constructor. Now, the
      constructor of ORM models is required to be compatible with that of
      ModelBase class. Now that most models do not define a constructor, this is
      much easier to control, and much more logical.
      
      Also, remove an issue where assignments on a relationship field to an
      instance of a super class of the foreign model would raise an error. This
      was previously addressed by re-classing the instance in the
      ModelInstanceManager::getOrBuild(); however that design would create
      multiple instances of the same object in memory, which defeats one of the
      primary design concepts of the ORM. This patch addresses the issue by
      allowing super-classes of the declared foreign model in relationship
      assignments.
      1ba40e35
  10. Aug 18, 2015
  11. May 27, 2015
    • Jared Hancock's avatar
      c2908ebf
    • Jared Hancock's avatar
      Fix a few more reported issues · 590e8a31
      Jared Hancock authored
      * Fix crash saving a page (regression)
      * Fix red banner deleting a department
      * Fix crash deleting a knowledgebase article
      590e8a31
    • Jared Hancock's avatar
      Fix numerous issues with attachments · bdc4d127
      Jared Hancock authored
      * Fix attachments not sticking on new dynamic form entry
      * Fix attachments not sticking on thread post validation error
      * Fix missing inline images in FAQ article viewing
      * Fix missing inline images in FAQ article printing
      * Fix crash rendering sidebar in staff faq view with attachments
      * Rewrite GenericAttachments to be an ORM object
      * Port CannedResponse to ORM
      * Fix attachments not being displayed when editing a FAQ article
      * Fix squirly empty blue box on faq articles with no attachments
      bdc4d127
  12. Apr 30, 2015
  13. Feb 27, 2015
  14. Jan 14, 2015
  15. Jan 02, 2015
    • Jared Hancock's avatar
      oops: Fix several small, general issues · 79cc5338
      Jared Hancock authored
        * Fix translation of pages
        * Localize client thank-you page on new ticket
        * Fix adding new category
        * Fix crash on staff login when upgrading from < 1.9
        * Don't show self locks on ticket queue pages
      79cc5338
  16. Dec 31, 2014
    • Jared Hancock's avatar
      files: Provide unified download script · d9cf38bc
      Jared Hancock authored
      This script adds a single download script, 'file.php', which provides access
      to files of all types to all users. It uses a HMAC signature system with an
      expires time, which allows signed URLs to be sent to external users.
      
      This also fixes an issue with the Http::cacheable() method, where the
      last-modified and Etag headers were not properly compared, which resulted in
      permanent cache misses by the client.
      d9cf38bc
  17. Dec 08, 2014
  18. Jul 18, 2014
  19. Jul 08, 2014
  20. Jun 27, 2014
  21. May 09, 2014
  22. Mar 25, 2014
  23. Nov 14, 2013
  24. Oct 09, 2013
    • Jared Hancock's avatar
      HTML ticket thread, inline images and draft support · 864d3539
      Jared Hancock authored
      Process inline attachments in thread entry and support inline images in
      piped emails
      
      Support inline images across the system, with draft support
      
      Migrate to a single attachment table
          That way we don't need a new table for everything we need to attach an
          inline image to (like a signature, for instance)
      
      Add richtext support for internal notes
      
      Implement images on site pages
      
      * Image paste in Redactor
      * Make non-local images optional
      * Placeholder for non-local images
      * Fix local image download hover
      * Don't re-attach inline images
      864d3539
  25. Jul 10, 2013
  26. Jul 03, 2013
Loading