Skip to content
Snippets Groups Projects
  1. Jan 05, 2015
    • Jared Hancock's avatar
      oops: Fix several small, general issues · 1922920a
      Jared Hancock authored
        * Fix fatal errors adding a new FAQ (fixes #1648)
        * Fix removal of attachments when deleting a thread (fixes #1650)
        * Fix crash discovering department members for alerts (fixes #1652)
      1922920a
  2. Dec 11, 2014
  3. Dec 08, 2014
    • Jared Hancock's avatar
      i18n: Add locale-based date time formats · 0fbc09ad
      Jared Hancock authored
      This patch adds support for automatic date and time formatting based on a
      selection of locale. The locale can default to the system or user specified
      language+locale, or can be elected separately. For instance, English
      speakers can pick between US, GB, and many other English speaking locales.
      
      This also removes the need of the %timezone table and uses the timezonedb
      built into PHP 5.3+. User's can now select from a much longer list of
      database and no longer need to deal with the DST checkbox.
      0fbc09ad
  4. Oct 20, 2014
  5. Oct 06, 2014
  6. Sep 10, 2014
    • Jared Hancock's avatar
      email: Improve user identification from headers · 67782d9a
      Jared Hancock authored
      Previously, the code would scan the email headers until it found a positive
      match from any of the email headers scanned. Additionally, it would attempt
      to find the user from the tagged email references header. However, this
      algorithm assumed that the references header was constant and predictable in
      its ordering. Recent tests with Gmail prove otherwise in some tests.
      
      This patch changes the system so that only the tagged reference header is
      included in the References header, and it will scan all items in a header
      (namely the References header) until both the thread and a user are
      identified. If a user can be identified, the thread and user are returned.
      Otherwise, the first thread hit is returned.
      67782d9a
  7. Sep 09, 2014
  8. Sep 04, 2014
  9. Aug 29, 2014
    • Jared Hancock's avatar
      forms: Unify attachment settings · 9fc4d080
      Jared Hancock authored
      Attachment settings are now exclusively handled by the settings on the
      ThreadEntry field on the ticket details form. Enabling attachments as well
      as tuning attachment validation settings are all handled from the one place
      now.
      9fc4d080
  10. Aug 14, 2014
  11. Aug 07, 2014
  12. Jul 29, 2014
    • Jared Hancock's avatar
      Implement concept of custom ticket numbers · 5cfa1f97
      Jared Hancock authored
      Ticket numbers are now configurable as a system-default and by help topic.
      Previously, an administrator could select between six-digit random and
      sequential numbers. Now, the sequence is selectable so multiple sequences
      as needed, and a format can be specified to define how the ticket numbers
      look. Formats can also be defined for each help topic.
      5cfa1f97
  13. Jun 27, 2014
  14. Jun 25, 2014
    • Thane de Loth's avatar
      Adopt translation work from Thane de Loth · 7042e6c8
      Thane de Loth authored
      Multilanguage Support via gettext
      
      - added gettext encapsulations to all texts i thought necessary
      - added fallback function for the case that the gettext extension isn't loaded
      - added browser language detection
      - added gettext to the list of optional extensions in setup
      - rewritten some of the texts to use sprintf instead of appending strings
      - added german translation file
      - removed mark_overdue-confirm from cannedresponses.inc.php
      
      extend multi language support and a fex fixes
      
      - Better detection of translation files
      - Added functionality to redirect language codes (see redirecting
      language codes)
      - Ticket Status can be translated
      - The Datepicker can be translated
      - Extended functionality of 'testlang.php' to show what language code is
      used to translate
      
      Forgotten to apply a patch from RC5 to RC6
      
      - Forgotten to change $var to $vars in line 380 of class.mailfetch.php
      - Removed unneeded comment
      
      Added php_gettext as primary translation engine
      
      - Added php_gettext support (thanks to Danilo Segan and Steven
      Armstrong)
      - php_gettext is now the primary translation engine
      - Extended language detection functionality
      
      Add error/misconfiguration checks and fix undefined variables
      7042e6c8
  15. Jun 05, 2014
  16. May 30, 2014
    • Jared Hancock's avatar
      thread: Add searchable view to ThreadBody · a00876a2
      Jared Hancock authored
      This will be useful for plugins which might need to scan the message body
      regardless of its encoding. This will also be required for full-text indexes
      which will not need to index HTML tags, for instance.
      a00876a2
  17. May 22, 2014
  18. May 20, 2014
    • Jared Hancock's avatar
      thread: Fixup link URLs for emails · 2ed876a2
      Jared Hancock authored
      This patch adds an 'email' format to ThreadBody::display() which allows
      formatting the html/text bodies specifically for email. Previously, there
      was ambiguity between the html view (which included inline image support and
      clickable links) and the email view, which requires neither.
      2ed876a2
  19. May 13, 2014
    • Jared Hancock's avatar
      thread: Detect inline and separate attachments · 3eef5c84
      Jared Hancock authored
      If an email contains both inline and separate attachments, the previous
      logic would detect all the attachments as inline.
      
      Separate attachments have the `cid` set to `false`. This will pass the
      `isset` test, which would cause the logic to search through the body for a
      string of `cid:`, which would very likely be found if there was another
      inline image somewhere in the body of the email.
      3eef5c84
  20. May 12, 2014
    • Jared Hancock's avatar
      thread: Always embed HTML in email templates · a2d15dff
      Jared Hancock authored
      With the advent of 1.9, the original, plain text email is saved in the
      thread table. If a system has the HTML ticket thread enabled (which is the
      default), if the plain text message is placed in the email template (which
      is always HTML), it will not be formatted as correct HTML and the whitespace
      will be collapsed.
      
      This patch addresses the issue by always returning HTML from the asVar()
      method, which is used to embed the thread post into a email template.
      a2d15dff
  21. May 09, 2014
  22. May 08, 2014
  23. Apr 16, 2014
  24. Apr 15, 2014
  25. Apr 14, 2014
    • Jared Hancock's avatar
      Relax detection of images for strip detection · f8b490d0
      Jared Hancock authored
      It is perfectectly fine to have an image cited in an HTML body similar to:
      
      <img width=909 height=302 src=cid:image002.jpg@01CF5426.BF5A72A0 alt=image>
      
      Which may or may not have quoted @src attribute, and may very well have an
      at sign (@) somewhere in the attribute text. The previous regular expression
      would not match such a @src attribute.
      f8b490d0
    • Jared Hancock's avatar
      Inline images in email without a 'cid:' indicator · 3c3ffbfa
      Jared Hancock authored
      It is the defacto standard to reference an inline image in an email by
      referencing the Content-ID header of the referenced attachment in the @src
      attribute of the image. For instance, `<imc src="cid:image001.png">` where
      the `cid:` scheme of the attribute indicates that the referenced image URL
      is a separate content of the email. The image attached to the email would
      have an accompanying header like: `Content-Id: <image001.png>`. However,
      some mail systems, including a certain fax to email service, do not
      correctly indicate the location of the image with the content-id URL.
      Instead, the referenced image tag would be `<img src="image001.png">`
      
      This patch addresses the issue by searching the message body for all
      references to attached content-id's in all @src attributes with or without
      the content-id URL scheme indicator. Previously, such images would not be
      displayed inline in the ticket thread.
      
      References:
      https://tools.ietf.org/html/rfc2392
      3c3ffbfa
  26. Apr 11, 2014
  27. Apr 10, 2014
    • Jared Hancock's avatar
      Relax detection of images for strip detection · b707b871
      Jared Hancock authored
      It is perfectectly fine to have an image cited in an HTML body similar to:
      
      <img width=909 height=302 src=cid:image002.jpg@01CF5426.BF5A72A0 alt=image>
      
      Which may or may not have quoted @src attribute, and may very well have an
      at sign (@) somewhere in the attribute text. The previous regular expression
      would not match such a @src attribute.
      b707b871
Loading