Skip to content
Snippets Groups Projects
  1. Jun 06, 2016
  2. Apr 26, 2016
  3. Apr 25, 2016
  4. Apr 24, 2016
  5. Apr 20, 2016
  6. Apr 19, 2016
    • Jared Hancock's avatar
    • Jared Hancock's avatar
      orm: Propagate LEFT joins in join paths · 6be61133
      Jared Hancock authored
      If something like members__staff is considered leaving the Team model,
      and the `members` relationship is nullable, and the `staff` relationship is
      not, in the context of the compiled SQL statement, the second join should
      also be considered nullable (LEFT join), because otherwise inconsistent
      results would be returned from the query.
      
      In other words, if a count is considered as an annotation to the Team model
      instances, Teams with zero members should still be considered as valid teams
      and should be selected with such an annotation. Before this patch, however,
      the join between TeamMember and Staff would have been an inner join instead
      of a LEFT join, which could skew the database results.
      6be61133
Loading