i18n: Fix several lint errors

Also, the final version of the system will not require the `gettext`
extension for PHP

include/staff/system.inc.php

@@ -43,10 +43,6 @@ $commit = GIT_VERSION != '$git' ? GIT_VERSION : (
                     echo extension_loaded('json')?'check':'warning-sign'; ?>"></i></td>
                 <td>json</td>
                 <td><?php echo __('Improves performance creating and processing JSON'); ?></td></tr>
-            <tr><td><i class="icon icon-<?php
-                    echo extension_loaded('gettext')?'check':'warning-sign'; ?>"></i></td>
-                <td>gettext</td>
-                <td><?php echo __('Improves performance for non US-English configurations'); ?></td></tr>
             <tr><td><i class="icon icon-<?php
                     echo extension_loaded('mbstring')?'check':'warning-sign'; ?>"></i></td>
                 <td>mbstring</td>

setup/cli/modules/i18n.php

@@ -199,6 +199,7 @@ class i18n_Compiler extends Module {
         }
 
         // Add in translation of javascript strings
+        $phrases = array();
         if ($mo && ($js = $this->__getAllJsPhrases())) {
             $mo = unserialize($mo);
             foreach ($js as $c) {

setup/inc/install-prereq.inc.php

@@ -32,8 +32,6 @@ if(!defined('SETUPINC')) die('Kwaheri!');
                     echo __('(for HTML email processing)');?></li>
                 <li class="<?php echo extension_loaded('json')?'yes':'no'; ?>">PHP JSON <?php echo __('extension');?> <?php
                     echo __('(faster performance)');?></li>
-                <li class="<?php echo extension_loaded('gettext')?'yes':'no'; ?>">Gettext <?php echo __('extension');?> &mdash; <?php
-                    echo __('used for translations');?> <?php echo __('(faster performance)');?></li>
                 <li class="<?php echo extension_loaded('mbstring')?'yes':'no'; ?>">Mbstring <?php echo __('extension');?> &mdash; <?php
                     echo __('recommended for all installations');?></li>
                 <li class="<?php echo extension_loaded('phar')?'yes':'no'; ?>">Phar <?php echo __('extension');?> &mdash; <?php

setup/test/tests/stubs.php

@@ -93,6 +93,8 @@ class DateTimeZone {
 class Phar {
     static function isValidPharFilename() {}
     function setStub() {}
+    function startBuffering() {}
+    function stopBuffering() {}
 }
 
 class ZipArchive {
@@ -106,4 +108,8 @@ class finfo {
     function file() {}
     function buffer() {}
 }
+
+class Locale {
+    function getDisplayName() {}
+}
 ?>