Deprecate 'show_related_tickets'

Client accounts now that the user is verified either via staff or the
client's email mailbox, there's a much lower risk to showing a verified user
other tickets and virtually no reason that an administrator should have to
turn the feature on.

include/class.config.php

@@ -296,10 +296,6 @@ class OsticketConfig extends Config {
         return $this->get('passwd_reset_period');
     }
 
-    function showRelatedTickets() {
-        return $this->get('show_related_tickets');
-    }
-
     function isHtmlThreadEnabled() {
         return $this->get('enable_html_thread');
     }

include/class.nav.php

@@ -282,7 +282,7 @@ class UserNav {
 
             $navs['new']=array('desc'=>'Open New Ticket','href'=>'open.php','title'=>'');
             if($user && $user->isValid()) {
-                if(!$user->isGuest() && $cfg && $cfg->showRelatedTickets()) {
+                if(!$user->isGuest()) {
                     $navs['tickets']=array('desc'=>sprintf('Tickets (%d)',$user->getNumTickets()),
                                            'href'=>'tickets.php',
                                             'title'=>'Show all tickets');

include/client/header.inc.php

@@ -48,11 +48,7 @@ header("Content-Type: text/html; charset=UTF-8\r\n");
                  echo Format::htmlchars($thisclient->getName()).' |';
                  ?>
                 <a href="<?php echo ROOT_PATH; ?>account.php">Profile</a> |
-                <?php
-                if($cfg->showRelatedTickets()) {?>
                 <a href="<?php echo ROOT_PATH; ?>tickets.php">Tickets <b>(<?php echo $thisclient->getNumTickets(); ?>)</b></a> -
-                <?php
-                } ?>
                 <a href="<?php echo ROOT_PATH; ?>logout.php?auth=<?php echo $ost->getLinkToken(); ?>">Log Out</a>
              <?php
              }elseif($nav){ ?>

include/client/tickets.inc.php

 <?php
-if(!defined('OSTCLIENTINC') || !is_object($thisclient) || !$thisclient->isValid() || !$cfg->showRelatedTickets()) die('Access Denied');
+if(!defined('OSTCLIENTINC') || !is_object($thisclient) || !$thisclient->isValid()) die('Access Denied');
 
 $qstr='&'; //Query string collector
 $status=null;

include/staff/settings-tickets.inc.php

@@ -76,13 +76,6 @@ if(!($maxfileuploads=ini_get('max_file_uploads')))
                 <em>(Minutes to lock a ticket on activity - enter 0 to disable locking)</em>
             </td>
         </tr>
-        <tr>
-            <td width="180">Show Related Tickets:</td>
-            <td>
-                <input type="checkbox" name="show_related_tickets" value="1" <?php echo $config['show_related_tickets'] ?'checked="checked"':''; ?> >
-                <em>(Show all related tickets on user login - otherwise access is restricted to one ticket view per login)</em>
-            </td>
-        </tr>
         <tr>
             <td>Human Verification:</td>
             <td>

include/upgrader/streams/core/f5692e24-4323a6a8.patch.sql

@@ -85,6 +85,9 @@ CREATE TABLE `%TABLE_PREFIX%organization` (
   PRIMARY KEY (`id`)
 ) DEFAULT CHARSET=utf8;
 
+DELETE FROM `%TABLE_PREFIX%config` where `namespace`='core'
+    AND `key` = 'show_related_tickets';
+
 -- Finished with patch
 UPDATE `%TABLE_PREFIX%config`
     SET `value` = '4323a6a81c35efbf7722b7fc4e475440'

tickets.php

@@ -102,7 +102,7 @@ if($ticket && $ticket->checkUserAccess($thisclient)) {
     }
     else
         $inc='view.inc.php';
-} elseif($cfg->showRelatedTickets() && $thisclient->getNumTickets()) {
+} elseif($thisclient->getNumTickets()) {
     $inc='tickets.inc.php';
 } else {
     $nav->setActiveNav('new');