oops: Fix warning on new ticket page for Thread::lastmessage

include/ajax.staff.php

@@ -29,6 +29,7 @@ class StaffAjaxAPI extends AjaxController {
           Http::response(404, 'No such agent');
 
       $form = new PasswordResetForm($_POST);
+      $errors = array();
       if (!$_POST && isset($_SESSION['new-agent-passwd']))
           $form->data($_SESSION['new-agent-passwd']);
 
@@ -76,6 +77,7 @@ class StaffAjaxAPI extends AjaxController {
             Http::response(404, 'No such agent');
 
         $form = new PasswordChangeForm($_POST);
+        $errors = array();
 
         if ($_POST && $form->isValid()) {
             $clean = $form->getClean();

include/class.format.php

@@ -869,8 +869,6 @@ implements TemplateVariable {
     }
 
     function getVar($what) {
-        global $cfg;
-
         // TODO: Rebase date format so that locale is discovered HERE.
 
         switch ($what) {
@@ -906,20 +904,21 @@ extends FormattedLocalDate {
         return (string) new FormattedLocalDate($this->date, $cfg->getTimezone(), false, $this->fromdb);
     }
 
-    function getVar($what, $context) {
+    function getVar($what, $context=null) {
         global $cfg;
 
-        if ($rv = parent::getVar($what))
+        if ($rv = parent::getVar($what, $context))
             return $rv;
 
         switch ($what) {
         case 'user':
             // Fetch $recipient from the context and find that user's time zone
-            if ($recipient = $context->getObj('recipient')) {
+            if ($context && ($recipient = $context->getObj('recipient'))) {
                 $tz = $recipient->getTimezone() ?: $cfg->getDefaultTimezone();
                 return new FormattedLocalDate($this->date, $tz, $recipient);
             }
-            break;
+            // Don't resolve the variable until correspondance is sent out
+            return false;
         case 'system':
             return new FormattedLocalDate($this->date, $cfg->getDefaultTimezone());
         }

include/class.thread.php

@@ -2447,7 +2447,7 @@ implements TemplateVariable {
             return $message;
 
         $this->lastmessage = SqlFunction::NOW();
-        $this->save();
+        $this->save(true);
         return $message;
     }
 
@@ -2460,7 +2460,7 @@ implements TemplateVariable {
             return $resp;
 
         $this->lastresponse = SqlFunction::NOW();
-        $this->save();
+        $this->save(true);
         return $resp;
     }