Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
O
osticket
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
docker
osticket
Commits
dd626c35
Commit
dd626c35
authored
11 years ago
by
Peter Rotich
Browse files
Options
Downloads
Patches
Plain Diff
Improve navigation of user pages
Link to org & user landing pages & kill pjax on internal pages
parent
4010b27a
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
include/staff/footer.inc.php
+2
-1
2 additions, 1 deletion
include/staff/footer.inc.php
include/staff/templates/ticket-preview.tmpl.php
+11
-8
11 additions, 8 deletions
include/staff/templates/ticket-preview.tmpl.php
include/staff/user-view.inc.php
+2
-3
2 additions, 3 deletions
include/staff/user-view.inc.php
with
15 additions
and
12 deletions
include/staff/footer.inc.php
+
2
−
1
View file @
dd626c35
...
...
@@ -26,7 +26,8 @@ if(is_object($thisstaff) && $thisstaff->isStaff()) { ?>
if
(
$
.
support
.
pjax
)
{
$
(
document
).
on
(
'
click
'
,
'
a
'
,
function
(
event
)
{
if
(
!
$
(
this
).
hasClass
(
'
no-pjax
'
)
&&
!
$
(
this
).
closest
(
'
.no-pjax
'
).
length
)
&&
!
$
(
this
).
closest
(
'
.no-pjax
'
).
length
&&
$
(
this
).
attr
(
'
href
'
)[
0
]
!=
'
#
'
)
$
.
pjax
.
click
(
event
,
{
container
:
$
(
'
#pjax-container
'
),
timeout
:
2000
});
})
}
...
...
This diff is collapsed.
Click to expand it.
include/staff/templates/ticket-preview.tmpl.php
+
11
−
8
View file @
dd626c35
...
...
@@ -95,7 +95,7 @@ echo sprintf(
'
<tr>
<th>From:</th>
<td>
%s
<span class="faded">%s</span></td>
<td>
<a href="users.php?id=%d" class="no-pjax">%s</a>
<span class="faded">%s</span></td>
</tr>
<tr>
<th width="100">Department:</th>
...
...
@@ -105,6 +105,7 @@ echo sprintf(
<th>Help Topic:</th>
<td>%s</td>
</tr>'
,
$ticket
->
getUserId
(),
Format
::
htmlchars
(
$ticket
->
getName
()),
$ticket
->
getEmail
(),
Format
::
htmlchars
(
$ticket
->
getDeptName
()),
...
...
@@ -118,14 +119,16 @@ echo '</div>'; // ticket preview content.
<table
border=
"0"
cellspacing=
""
cellpadding=
"1"
>
<colgroup><col
style=
"min-width: 250px;"
></col></colgroup>
<?php
if
((
$
user
s
=
$ticket
->
getCollaborators
()))
{
?>
if
((
$
collab
s
=
$ticket
->
getCollaborators
()))
{
?>
<?php
foreach
(
$users
as
$user
)
{
echo
sprintf
(
'<tr><td %s><i class="icon-%s"></i> %s <em><%s></em></td></tr>'
,
(
$user
->
isActive
()
?
''
:
'class="faded"'
),
(
$user
->
isActive
()
?
'comments'
:
'comment-alt'
),
$user
->
getName
(),
$user
->
getEmail
());
foreach
(
$collabs
as
$collab
)
{
echo
sprintf
(
'<tr><td %s><i class="icon-%s"></i>
<a href="users.php?id=%d" class="no-pjax">%s</a> <em><%s></em></td></tr>'
,
(
$collab
->
isActive
()
?
''
:
'class="faded"'
),
(
$collab
->
isActive
()
?
'comments'
:
'comment-alt'
),
$collab
->
getUserId
(),
$collab
->
getName
(),
$collab
->
getEmail
());
}
}
else
{
echo
"Ticket doesn't have collaborators."
;
...
...
This diff is collapsed.
Click to expand it.
include/staff/user-view.inc.php
+
2
−
3
View file @
dd626c35
...
...
@@ -84,9 +84,8 @@ $org = $user->getOrganization();
<span
id=
"user-
<?php
echo
$user
->
getId
();
?>
-org"
>
<?php
if
(
$org
)
echo
sprintf
(
'<a href="#users/%d/org"
class="user-action">%s</a>'
,
$user
->
getId
(),
$org
->
getName
());
echo
sprintf
(
'<a href="orgs.php?id=%d">%s</a>'
,
$org
->
getId
(),
$org
->
getName
());
else
echo
sprintf
(
'<a href="#users/%d/org"
class="user-action">Add Organization</a>'
,
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment