Merge remote branch 'adriane/issues/misc-fixes' into develop-next

Conflicts:
	WHATSNEW.md

WHATSNEW.md

 osTicket 1.11.0-rc.1
-==================
+====================
 ## Major New Features
-- Custom Columns/Custom Queues
-- Inline Edit
-- Ticket Referral
-- CC/BCC
-- Export Agent CSV
-- Department Access CSV
-- Archive Help Topics/Departments
-- Nested Knowledgebase Categories
+* Create Ticket or Task from Thread Entry
+* Custom Columns/Custom Queues
+* Inline Edit
+* Ticket Referral
+* CC/BCC
+* Export Agent CSV
+* Department Access CSV
+* Archive Help Topics/Departments
+* Nested Knowledgebase Categories
 
 ### Enhancements
-- Dashboard Statistics
-- Fix Vimeo iFrames
-- Fix randNumber()
-- Section Break Hint
-- List & Choice Searching (#3703, #3493, #2625)
-- Adds osTicket Favicons (#4112)
-- Fix Most Redactor Issues (#3849)
-- Send Login Errors Still Sends (#4073)
-- Private FAQs In Sidebar Search
-- User Password Reset (#4030)
-- Disabled & Private Help Topic (#3538)
-- Helpdesk Status Help Tip
-- Local Names In Validation Errors
-- User Registration Form (#4043)
-- Organization User List Pages Link (#4116)
-- Ticket Edit Internal Note (#4028)
-- Disable Canned Responses On New Ticket (#3971)
-- Canned Response Margin
-- Ticket Preview Custom Fields
-- Help Topic SLA (#3979)
-- Fix Agent Identity Masking (#2955, #3524)
-- Force Keys For Choice Field Options (#4071)
-- Check Missing Required Fields
-- Task Action Button Styling
-- Add Fullscreen To Embedded Videos
-- Fix Serbian Flag Icon (#3952)
-- Optimize Lock Table
-- Fix Outdated Alerts Link (#3935)
-- Fix Default Dept. Private Error (#3934)
-- Mailto TLD Length (#4063)
-- Remove Primary Contacts (#3903)
-- Fix Reset Button(s) (#3670)
-- Newsletter Link
-- Offline Page Images (#3869)
-- User Login Page Translation (#3860)
-- Translate Special Characters (#3842)
-- Custom Form Deletion (#3542, #4059)
-- Client Side Long FAQ Title (#3380)
-- Client FAQ Last Updated Time (#3475)
-- Email Banlist Sorting (#3452)
-- Fix New Ticket Cancel Button (#2624, #2881)
-- SQL Error Unknown column 'relevance' (#2655)
-- Fixes issue with last_update ticket variable
-- Ticket Notice Alert
-- Fix CSRF fail + shake effect (#3928, #3546)
-- Issue/ticket preview collabs
-- Allowing translation of copyrights in footers
-- User/Organization are not translated (#3650)
-- Fix DatePicker on client side (#3625, #3817, #3804, 0fbc09a)
-- Add Custom Forms to Ticket Filter Data
-- Fix for LDAP/AD auth plugin (#4198, #3460, #3544, #3549)
+* Fix Custom Department Field (#3976)
+* Remove Future Search/Filter Criteria if Invalid
+* Dashboard Statistics
+* Fix Vimeo iFrames
+* Fix randNumber()
+* Section Break Hint
+* List & Choice Searching (#3703, #3493, #2625)
+* Adds osTicket Favicons (#4112)
+* Fix Most Redactor Issues (#3849)
+* Send Login Errors Still Sends (#4073)
+* Private FAQs In Sidebar Search
+* User Password Reset (#4030)
+* Disabled & Private Help Topic (#3538)
+* Helpdesk Status Help Tip
+* Local Names In Validation Errors
+* User Registration Form (#4043)
+* Organization User List Pages Link (#4116)
+* Ticket Edit Internal Note (#4028)
+* Disable Canned Responses On New Ticket (#3971)
+* Canned Response Margin
+* Ticket Preview Custom Fields
+* Help Topic SLA (#3979)
+* Fix Agent Identity Masking (#2955, #3524)
+* Force Keys For Choice Field Options (#4071)
+* Check Missing Required Fields
+* Task Action Button Styling
+* Add Fullscreen To Embedded Videos
+* Fix Serbian Flag Icon (#3952)
+* Optimize Lock Table
+* Fix Outdated Alerts Link (#3935)
+* Fix Default Dept. Private Error (#3934)
+* Mailto TLD Length (#4063)
+* Remove Primary Contacts (#3903)
+* Fix Reset Button(s) (#3670)
+* Newsletter Link
+* Offline Page Images (#3869)
+* User Login Page Translation (#3860)
+* Translate Special Characters (#3842)
+* Custom Form Deletion (#3542, #4059)
+* Client Side Long FAQ Title (#3380)
+* Client FAQ Last Updated Time (#3475)
+* Email Banlist Sorting (#3452)
+* Fix New Ticket Cancel Button (#2624, #2881)
+* SQL Error Unknown column 'relevance' (#2655)
+* Fixes issue with last_update ticket variable
+* Ticket Notice Alert
+* Fix CSRF fail + shake effect (#3928, #3546)
+* Issue/ticket preview collabs
+* Allowing translation of copyrights in footers
+* User/Organization are not translated (#3650)
+* Fix DatePicker on client side (#3625, #3817, #3804, 0fbc09a)
+* Add Custom Forms to Ticket Filter Data
+* Fix for LDAP/AD auth plugin (#4198, #3460, #3544, #3549)
 
 osTicket v1.10.3
 ================

include/class.thread_actions.php

@@ -526,7 +526,7 @@ JS
         }
 
         if ($this->entry->getThread()->getObjectType()  == 'T')
-          return $this->getTicketsAPI()->addTask($this->getObjectId(), $vars); //TasksAjaxAPI
+          return $this->getTicketsAPI()->addTask($this->getObjectId(), $vars);
         else
           return $this->getTasksAPI()->add($this->getObjectId(), $vars);
 
@@ -534,9 +534,9 @@ JS
 
     private function trigger__post() {
       if ($this->entry->getThread()->getObjectType()  == 'T')
-        return $this->getTicketsAPI()->addTask($this->getObjectId(), $vars);
+        return $this->getTicketsAPI()->addTask($this->getObjectId());
       else
-        return $this->getTasksAPI()->add($this->getObjectId(), $vars);
+        return $this->getTasksAPI()->add($this->getObjectId());
     }
 
 }