Merge pull request #2411 from protich/issue/zombie-tickets

bug: Zombie tickets

Reviewed-By: Jared Hancock <jared@osticket.com>

include/class.dept.php

@@ -530,7 +530,7 @@ implements TemplateVariable {
     }
 
     static function __create($vars, &$errors) {
-        $dept = self::create();
+        $dept = self::create($vars);
         $dept->update($vars, $errors);
 
         return isset($dept->id) ? $dept : null;

include/class.i18n.php

@@ -64,8 +64,6 @@ class Internationalization {
             'ticket_status.yaml' => 'TicketStatus::__create',
             // Role
             'role.yaml' =>          'Role::__create',
-            // Note that group requires department
-            'group.yaml' =>         'Group::__create',
             'file.yaml' =>          'AttachmentFile::__create',
             'sequence.yaml' =>      'Sequence::__create',
         );

include/class.topic.php

@@ -281,7 +281,9 @@ implements TemplateVariable {
     }
 
     static function __create($vars, &$errors) {
-        $topic = self::create();
+        $topic = self::create($vars);
+        if (!isset($vars['dept_id']))
+            $vars['dept_id'] = 0;
         $topic->update($vars, $errors);
         return $topic;
     }

include/i18n/en_US/help_topic.yaml

@@ -21,7 +21,6 @@
 - topic_id: 1
   isactive: 1
   ispublic: 1
-  dept_id: 1
   priority_id: 2
   forms: [2]
   topic: General Inquiry
@@ -30,7 +29,6 @@
 
 - isactive: 1
   ispublic: 1
-  dept_id: 1
   priority_id: 1
   forms: [2]
   topic: Feedback
@@ -40,7 +38,7 @@
 - topic_id: 10
   isactive: 1
   ispublic: 1
-  dept_id: 1
+  dept_id: 3
   priority_id: 2
   forms: [2]
   topic: Report a Problem
@@ -50,7 +48,6 @@
 - topic_pid: 10
   isactive: 1
   ispublic: 1
-  dept_id: 1
   sla_id: 1
   priority_id: 3
   forms: [2]