Merge pull request #1435 from stevepacker/patch-1

createTicket respects alert/autorespond negatives

Reviewed-By: Peter Rotich <peter@osticket.com>

include/api.tickets.php

@@ -118,9 +118,11 @@ class TicketApiController extends ApiController {
     function createTicket($data) {
 
         # Pull off some meta-data
-        $alert = $data['alert'] ? $data['alert'] : true;
-        $autorespond = $data['autorespond'] ? $data['autorespond'] : true;
-        $data['source'] = $data['source'] ? $data['source'] : 'API';
+        $alert       = (bool) (isset($data['alert'])       ? $data['alert']       : true);
+        $autorespond = (bool) (isset($data['autorespond']) ? $data['autorespond'] : true);
+
+        # Assign default value to source if not defined, or defined as NULL
+        $data['source'] = isset($data['source']) ? $data['source'] : 'API';
 
         # Create the ticket with the data (attempt to anyway)
         $errors = array();

include/class.api.php

@@ -330,9 +330,9 @@ class ApiXmlDataParser extends XmlDataParser {
             if ($key == "phone" && is_array($value)) {
                 $value = $value[":text"];
             } else if ($key == "alert") {
-                $value = (bool)$value;
+                $value = (bool) (strtolower($value) === 'false' ? false : $value);
             } else if ($key == "autorespond") {
-                $value = (bool)$value;
+                $value = (bool) (strtolower($value) === 'false' ? false : $value);
             } else if ($key == "message") {
                 if (!is_array($value)) {
                     $value = array(