Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
O
osticket
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
docker
osticket
Commits
4c5292cb
Commit
4c5292cb
authored
9 years ago
by
Jared Hancock
Browse files
Options
Downloads
Patches
Plain Diff
install: Fix code include() crash
parent
edefc01b
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
bootstrap.php
+1
-2
1 addition, 2 deletions
bootstrap.php
include/class.forms.php
+0
-2
0 additions, 2 deletions
include/class.forms.php
setup/inc/class.installer.php
+13
-11
13 additions, 11 deletions
setup/inc/class.installer.php
with
14 additions
and
15 deletions
bootstrap.php
+
1
−
2
View file @
4c5292cb
...
@@ -191,14 +191,13 @@ class Bootstrap {
...
@@ -191,14 +191,13 @@ class Bootstrap {
#include required files
#include required files
require_once
INCLUDE_DIR
.
'class.util.php'
;
require_once
INCLUDE_DIR
.
'class.util.php'
;
require_once
INCLUDE_DIR
.
'class.translation.php'
;
require_once
INCLUDE_DIR
.
'class.translation.php'
;
require
(
INCLUDE_DIR
.
'class.signal.php'
);
require
_once
(
INCLUDE_DIR
.
'class.signal.php'
);
require
(
INCLUDE_DIR
.
'class.model.php'
);
require
(
INCLUDE_DIR
.
'class.model.php'
);
require
(
INCLUDE_DIR
.
'class.user.php'
);
require
(
INCLUDE_DIR
.
'class.user.php'
);
require
(
INCLUDE_DIR
.
'class.auth.php'
);
require
(
INCLUDE_DIR
.
'class.auth.php'
);
require
(
INCLUDE_DIR
.
'class.pagenate.php'
);
//Pagenate helper!
require
(
INCLUDE_DIR
.
'class.pagenate.php'
);
//Pagenate helper!
require
(
INCLUDE_DIR
.
'class.log.php'
);
require
(
INCLUDE_DIR
.
'class.log.php'
);
require
(
INCLUDE_DIR
.
'class.crypto.php'
);
require
(
INCLUDE_DIR
.
'class.crypto.php'
);
require_once
(
INCLUDE_DIR
.
'class.signal.php'
);
require
(
INCLUDE_DIR
.
'class.page.php'
);
require
(
INCLUDE_DIR
.
'class.page.php'
);
require_once
(
INCLUDE_DIR
.
'class.format.php'
);
//format helpers
require_once
(
INCLUDE_DIR
.
'class.format.php'
);
//format helpers
require_once
(
INCLUDE_DIR
.
'class.validator.php'
);
//Class to help with basic form input validation...please help improve it.
require_once
(
INCLUDE_DIR
.
'class.validator.php'
);
//Class to help with basic form input validation...please help improve it.
...
...
This diff is collapsed.
Click to expand it.
include/class.forms.php
+
0
−
2
View file @
4c5292cb
...
@@ -3427,8 +3427,6 @@ class DatetimePickerWidget extends Widget {
...
@@ -3427,8 +3427,6 @@ class DatetimePickerWidget extends Widget {
// TODO: Add time picker -- requires time picker or selection with
// TODO: Add time picker -- requires time picker or selection with
// Misc::timeDropdown
// Misc::timeDropdown
echo
' '
.
Misc
::
timeDropdown
(
$hr
,
$min
,
$this
->
name
.
':time'
);
echo
' '
.
Misc
::
timeDropdown
(
$hr
,
$min
,
$this
->
name
.
':time'
);
echo
'</div>'
;
}
}
/**
/**
...
...
This diff is collapsed.
Click to expand it.
setup/inc/class.installer.php
+
13
−
11
View file @
4c5292cb
...
@@ -73,13 +73,6 @@ class Installer extends SetupWizard {
...
@@ -73,13 +73,6 @@ class Installer extends SetupWizard {
//Admin's pass confirmation.
//Admin's pass confirmation.
if
(
!
$this
->
errors
&&
strcasecmp
(
$vars
[
'passwd'
],
$vars
[
'passwd2'
]))
if
(
!
$this
->
errors
&&
strcasecmp
(
$vars
[
'passwd'
],
$vars
[
'passwd2'
]))
$this
->
errors
[
'passwd2'
]
=
__
(
'Password(s) do not match'
);
$this
->
errors
[
'passwd2'
]
=
__
(
'Password(s) do not match'
);
try
{
require_once
INCLUDE_DIR
.
'class.auth.php'
;
PasswordPolicy
::
checkPassword
(
$vars
[
'passwd'
],
null
);
}
catch
(
BadPassword
$e
)
{
$this
->
errors
[
'passwd'
]
=
$e
->
getMessage
();
}
//Check table prefix underscore required at the end!
//Check table prefix underscore required at the end!
if
(
$vars
[
'prefix'
]
&&
substr
(
$vars
[
'prefix'
],
-
1
)
!=
'_'
)
if
(
$vars
[
'prefix'
]
&&
substr
(
$vars
[
'prefix'
],
-
1
)
!=
'_'
)
...
@@ -118,16 +111,25 @@ class Installer extends SetupWizard {
...
@@ -118,16 +111,25 @@ class Installer extends SetupWizard {
}
}
}
}
// bailout on errors.
if
(
$this
->
errors
)
return
false
;
/*************** We're ready to install ************************/
/*************** We're ready to install ************************/
define
(
'ADMIN_EMAIL'
,
$vars
[
'admin_email'
]);
//Needed to report SQL errors during install.
define
(
'ADMIN_EMAIL'
,
$vars
[
'admin_email'
]);
//Needed to report SQL errors during install.
define
(
'TABLE_PREFIX'
,
$vars
[
'prefix'
]);
//Table prefix
define
(
'TABLE_PREFIX'
,
$vars
[
'prefix'
]);
//Table prefix
Bootstrap
::
defineTables
(
TABLE_PREFIX
);
Bootstrap
::
defineTables
(
TABLE_PREFIX
);
Bootstrap
::
loadCode
();
Bootstrap
::
loadCode
();
// Check password against password policy (after loading code)
try
{
PasswordPolicy
::
checkPassword
(
$vars
[
'passwd'
],
null
);
}
catch
(
BadPassword
$e
)
{
$this
->
errors
[
'passwd'
]
=
$e
->
getMessage
();
}
// bailout on errors.
if
(
$this
->
errors
)
return
false
;
$debug
=
true
;
// Change it to false to squelch SQL errors.
$debug
=
true
;
// Change it to false to squelch SQL errors.
//Last minute checks.
//Last minute checks.
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment