Skip to content
Snippets Groups Projects
  • Jared Hancock's avatar
    Handle attachment filenames better · b4b02114
    Jared Hancock authored
    Previously, filenames saved in the database had the spaces changed for
    underbars; however, other characters (such as commas and non-ascii
    characters) presented issues with user agents downloading the attachments.
    
    This patch handles the filename encoding for two special cases -- internet
    explorer and safari, and provides the semi-standard RFC5987 method of
    encoding the filename for the remaining browsers.
    
    Attachments are no longer forced to be downloaded. It is up to the browser
    to decide if the attachment should be shown in the browser or downloaded.
    
    This patch also fixes a slight bug in the caching mechanism for downloads
    concerning the last-modified time. The date sent to the browser was not
    properly converted to GMT time, although the server claimed that it was.
    b4b02114