Resolve "Login - logout shows Not authenticated error randomly" (!18) · Merge requests · Code / Vereign Client Library · GitLab

Snippets Groups Projects

Merged Igor Markin requested to merge 25-login-logout-shows-not-authenticated-error-randomly into master 6 years ago

1 unresolved thread

Closes #25 (closed)

Related MR in Dashboard https://code.vereign.com/code/dashboard/merge_requests/313

Edited 6 years ago by Igor Markin

Activity

Igor Markin @igor.markin 6 years ago

Author Maintainer

@damyan.mitev @viktor.popov please review.
Igor Markin added 1 commit 6 years ago
added 1 commit

95bb3fd6 - Fix setIdentityInLocalStorage for login mode sms.

Compare with previous version
Igor Markin added 4 commits 6 years ago
added 4 commits

c1591ae1 - Refactor window.authenticationPublicKey

52c145ff - refactor logout

2d006792 - Refactor setTimeout body.

6c539934 - Remove setting of currentlyAuthenticatedIdentity

Compare with previous version
Toggle commit list
Damyan Mitev added reviewed label 6 years ago

added reviewed label
Damyan Mitev @damyan.mitev 6 years ago

Contributor

Looks good
Viktor Popov added 1 deleted label 6 years ago

added 1 deleted label
Igor Markin changed the description 6 years ago

changed the description
Igor Markin added 8 commits 6 years ago
added 8 commits

d0c8e3a4 - 1 commit from branch master

ec86fd7f - Refactor login.

17cc7f19 - Fix resetting sessionData.

06b73401 - Fix setIdentityInLocalStorage for login mode sms.

6473f6e4 - Refactor window.authenticationPublicKey

e76b002a - refactor logout

07129b7d - Refactor setTimeout body.

d2b09de3 - Remove setting of currentlyAuthenticatedIdentity

Compare with previous version
Toggle commit list
Rosen Georgiev added ReadyForMergeInMaster label and removed DevInProgress label 6 years ago

added ReadyForMergeInMaster label and removed DevInProgress label
Rosen Georgiev assigned to @gospodin.bodurov 6 years ago

assigned to @gospodin.bodurov
Gospodin Bodurov @gospodin.bodurov started a thread on the diff 6 years ago

javascript/src/iframe/viamapi-iframe.js

2440	2386	}
2441	2387
2442	2388	case "KeyDeleted" : {
2443		window.authenticationPublicKey = localStorage.getItem("authenticatedIdentity");
Gospodin Bodurov @gospodin.bodurov 6 years ago Contributor Did you test this from two different tabs? Gospodin Bodurov @gospodin.bodurov 6 years ago Contributor @igor.markin @rosen.georgiev ? Rosen Georgiev @rosen.georgiev 6 years ago Developer Loging out from 1 tag removes the authentication of the other tab. If you refresh the 2nd tag it redirectes you to the login page. Currently on production this is not working. Logging out 1 tag doesn't log you from another tab. Gospodin Bodurov @gospodin.bodurov 6 years ago Contributor So I can merge it now? Igor Markin @igor.markin 6 years ago Author Maintainer Yes Please register or sign in to reply

Gospodin Bodurov merged 6 years ago

merged

Gospodin Bodurov mentioned in commit 6 years ago

mentioned in commit 04ce9979

Please register or sign in to reply