[17] crypto storage locking

cpp/tests/vereign/kvstore/lock_test.cc

+#include <vereign/kvstore/sqlite_storage.hh>
+
+#include <vereign/kvstore/lock.hh>
+#include <vereign/kvstore/errors.hh>
+#include <vereign/bytes/view_dump.hh>
+#include <vereign/core/fs.hh>
+#include <vereign/core/lock_guard.hh>
+#include <vereign/core/scope_guard.hh>
+#include <vereign/core/temp.hh>
+#include <vereign/crypto/rand.hh>
+#include <vereign/sqlite/errors.hh>
+#include <util/error.hh>
+#include <sqlite3.h>
+
+#include <catch2/catch.hpp>
+#include <boost/filesystem.hpp>
+#include <thread>
+#include <chrono>
+#include <limits>
+#include <optional>
+
+using namespace vereign;
+
+TEST_CASE("kvstore::Lock", "[vereign/kvstore]") {
+
+  SECTION("when the lock is released within the allowed retrials, the lock succeeds") {
+    auto storage_path = core::TempFilePath("test_db_");
+    core::RemoveFileGuard rm{storage_path};
+
+    auto foo_storage = kvstore::SqliteStorage(storage_path.string());
+    auto bar_storage = kvstore::SqliteStorage(storage_path.string());
+
+    foo_storage.Lock();
+
+    bool err = false;
+    auto th = std::thread{[&bar_storage, &err]() {
+      try {
+        kvstore::Lock l{bar_storage, std::numeric_limits<int>::max(), std::chrono::milliseconds{10}};
+      } catch (...) {
+        err = true;
+      }
+    }};
+
+    foo_storage.Unlock();
+    th.join();
+  }
+
+  SECTION("when the lock is not released within the allowed retrials, the lock fails") {
+    auto storage_path = core::TempFilePath("test_db_");
+    core::RemoveFileGuard rm{storage_path};
+
+    auto foo_storage = kvstore::SqliteStorage(storage_path.string());
+    auto bar_storage = kvstore::SqliteStorage(storage_path.string());
+
+    foo_storage.Lock();
+
+    CHECK_THROWS_AS(
+      kvstore::Lock(bar_storage, 2, std::chrono::milliseconds{1}),
+      kvstore::LockError
+    );
+  }
+}

cpp/tests/vereign/kvstore/sqlite_storage_test.cc

+#include <vereign/kvstore/sqlite_storage.hh>
+
+#include <vereign/kvstore/lock.hh>
+#include <vereign/kvstore/errors.hh>
+#include <vereign/bytes/view_dump.hh>
+#include <vereign/core/fs.hh>
+#include <vereign/core/scope_guard.hh>
+#include <vereign/core/temp.hh>
+#include <vereign/crypto/rand.hh>
+#include <vereign/sqlite/errors.hh>
+#include <util/error.hh>
+#include <sqlite3.h>
+
+#include <catch2/catch.hpp>
+#include <boost/filesystem.hpp>
+#include <thread>
+#include <optional>
+
+using namespace vereign;
+
+
+TEST_CASE("kvstore::SqliteStorage::DeleteAll", "[vereign/kvstore]") {
+  auto storage_path = core::TempFilePath("test_db_");
+  core::RemoveFileGuard rm{storage_path};
+
+  auto kvstorage = kvstore::SqliteStorage(storage_path.string());
+
+  kvstorage.PutInt64("foo", 42);
+  kvstorage.PutInt64("bar", 422);
+
+  CHECK(kvstorage.GetInt64("foo") == 42);
+  CHECK(kvstorage.GetInt64("bar") == 422);
+
+  kvstorage.DeleteAll();
+
+  CHECK(kvstorage.GetInt64("foo") == 0);
+  CHECK(kvstorage.GetInt64("bar") == 0);
+}
+
+TEST_CASE("kvstore::SqliteStorage::Lock", "[vereign/kvstore]") {
+
+  SECTION("when locked using lock guard, it must unlock on scope exit") {
+    auto storage_path = core::TempFilePath("test_db_");
+    core::RemoveFileGuard rm{storage_path};
+
+    {
+      auto kvstorage = kvstore::SqliteStorage(storage_path.string());
+
+      kvstore::Lock l{kvstorage};
+
+      kvstorage.PutInt64("foo", 42);
+      kvstorage.PutInt64("bar", 422);
+    }
+
+    {
+      auto kvstorage = kvstore::SqliteStorage(storage_path.string());
+
+      kvstore::Lock l{kvstorage};
+
+      CHECK(kvstorage.GetInt64("foo") == 42);
+      CHECK(kvstorage.GetInt64("bar") == 422);
+    }
+  }
+
+  SECTION("when locked, it must unlock on scope exit") {
+    auto storage_path = core::TempFilePath("test_db_");
+    core::RemoveFileGuard rm{storage_path};
+
+    {
+      auto kvstorage = kvstore::SqliteStorage(storage_path.string());
+      kvstorage.Lock();
+
+      kvstorage.PutInt64("foo", 42);
+      kvstorage.PutInt64("bar", 422);
+    }
+
+    {
+      auto kvstorage = kvstore::SqliteStorage(storage_path.string());
+      kvstorage.Lock();
+
+      CHECK(kvstorage.GetInt64("foo") == 42);
+      CHECK(kvstorage.GetInt64("bar") == 422);
+    }
+  }
+
+  SECTION("when the storage is already locked, it must fail with LockError") {
+    auto storage_path = core::TempFilePath("test_db_");
+    core::RemoveFileGuard rm{storage_path};
+
+    auto foo_storage = kvstore::SqliteStorage(storage_path.string());;
+    auto bar_storage = kvstore::SqliteStorage(storage_path.string());
+
+    foo_storage.Lock();
+
+    CHECK_THROWS_AS(bar_storage.Lock(), kvstore::LockError);
+  }
+}