From cc6f2a97c643f0a3bb9546cd1a942ba32b6ba3e9 Mon Sep 17 00:00:00 2001
From: sovrgn <boyan.tsolov@vereign.com>
Date: Wed, 11 Oct 2023 11:16:27 +0300
Subject: [PATCH] fix: added checks on dtos
---
.../dtos/generics/connection.record.dto.ts | 5 ----
.../src/dtos/generics/creddef.record.dto.ts | 6 -----
.../dtos/generics/credential.record.dto.ts | 23 -------------------
.../src/dtos/generics/proof.record.dto.ts | 6 -----
.../src/dtos/generics/schema.record.dto.ts | 10 ++++----
.../src/dtos/requests/connection.req.dto.ts | 5 ----
.../dtos/src/dtos/requests/creddef.req.dto.ts | 4 ----
.../src/dtos/requests/credential.req.dto.ts | 8 -------
libs/dtos/src/dtos/requests/proof.req.dto.ts | 6 -----
libs/dtos/src/dtos/requests/schema.req.dto.ts | 4 ----
10 files changed, 4 insertions(+), 73 deletions(-)
diff --git a/libs/dtos/src/dtos/generics/connection.record.dto.ts b/libs/dtos/src/dtos/generics/connection.record.dto.ts
index b48dbb9a..e7bd42e9 100644
--- a/libs/dtos/src/dtos/generics/connection.record.dto.ts
+++ b/libs/dtos/src/dtos/generics/connection.record.dto.ts
@@ -1,11 +1,6 @@
import { IsDateString, IsNotEmpty, IsString } from "class-validator";
import { BaseRecordDto } from "./base.record.dto";
-// INFO: should cover:
-
-// 1. get connection response
-// 2. accept connection response
-
export class ConnectionRecordDto extends BaseRecordDto {
@IsNotEmpty()
diff --git a/libs/dtos/src/dtos/generics/creddef.record.dto.ts b/libs/dtos/src/dtos/generics/creddef.record.dto.ts
index 70f29373..cf9d449b 100644
--- a/libs/dtos/src/dtos/generics/creddef.record.dto.ts
+++ b/libs/dtos/src/dtos/generics/creddef.record.dto.ts
@@ -2,12 +2,6 @@ import { IsNotEmpty, IsString } from "class-validator";
import { BaseRecordDto } from "./base.record.dto";
-// INFO: should cover:
-
-// 1. get credential definition response
-// 2. create credential definition response
-
-
export class CreddefRecordDto extends BaseRecordDto {
@IsNotEmpty()
diff --git a/libs/dtos/src/dtos/generics/credential.record.dto.ts b/libs/dtos/src/dtos/generics/credential.record.dto.ts
index 587a46d2..f14aa33d 100644
--- a/libs/dtos/src/dtos/generics/credential.record.dto.ts
+++ b/libs/dtos/src/dtos/generics/credential.record.dto.ts
@@ -1,6 +1,5 @@
import {
IsArray,
- IsDateString,
IsNotEmpty,
IsString,
ValidateNested,
@@ -10,29 +9,7 @@ import { IssueCredentialAttributes } from "../requests/issue.credential.request.
import { BaseRecordDto } from "./base.record.dto";
-// INFO: should cover:
-
-// 1. create credential response
-// 2. get credential response
-
-
-
-// export class Credential extends BaseRecordDto {
-// @IsNotEmpty()
-// @IsString()
-// credentialRecordType: string;
-
-// @IsNotEmpty()
-// @IsString()
-// credentialRecordId: string;
-// }
-
export class CredentialRecordDto extends BaseRecordDto {
- // @IsArray()
- // @ValidateNested({ each: true })
- // @Type(() => Credential)
- // credentials?: Array<Credential>;
-
@IsNotEmpty()
@IsString()
credentialRecordType: string;
diff --git a/libs/dtos/src/dtos/generics/proof.record.dto.ts b/libs/dtos/src/dtos/generics/proof.record.dto.ts
index 37ce14ce..4e59f88c 100644
--- a/libs/dtos/src/dtos/generics/proof.record.dto.ts
+++ b/libs/dtos/src/dtos/generics/proof.record.dto.ts
@@ -6,12 +6,6 @@ import {
import { BaseRecordDto } from "./base.record.dto";
-// INFO: should cover:
-
-// 1. decline proof response
-// 2. get proof response
-// 3. issue proof response
-
export class ProofRecordDto extends BaseRecordDto {
@IsString()
connectionId?: string;
diff --git a/libs/dtos/src/dtos/generics/schema.record.dto.ts b/libs/dtos/src/dtos/generics/schema.record.dto.ts
index bc5d219a..c9b51297 100644
--- a/libs/dtos/src/dtos/generics/schema.record.dto.ts
+++ b/libs/dtos/src/dtos/generics/schema.record.dto.ts
@@ -1,18 +1,16 @@
-import { IsDateString, IsNotEmpty, IsString } from "class-validator";
+import { ArrayMinSize, IsArray, IsNotEmpty, IsString } from "class-validator";
import { BaseRecordDto } from "./base.record.dto";
-// INFO: should cover:
-
-// 1. create schema response
-// 2. get schema response
-
export class SchemaRecordDto extends BaseRecordDto {
@IsString()
@IsNotEmpty()
name: string;
@IsNotEmpty()
+ @IsArray()
+ @IsString({ each: true })
+ @ArrayMinSize(1)
attributes: string[];
@IsNotEmpty()
diff --git a/libs/dtos/src/dtos/requests/connection.req.dto.ts b/libs/dtos/src/dtos/requests/connection.req.dto.ts
index 2c63d34c..cd091613 100644
--- a/libs/dtos/src/dtos/requests/connection.req.dto.ts
+++ b/libs/dtos/src/dtos/requests/connection.req.dto.ts
@@ -1,11 +1,6 @@
import { IsNotEmpty, IsString } from "class-validator";
-// INFO: should cover:
-
-// 1. get connection request
-
-
export class ConnectionReqDto {
//@example 6464b521-005a-4379-91e0-a3692b31cafd
@IsNotEmpty()
diff --git a/libs/dtos/src/dtos/requests/creddef.req.dto.ts b/libs/dtos/src/dtos/requests/creddef.req.dto.ts
index 37284a40..681e3eec 100644
--- a/libs/dtos/src/dtos/requests/creddef.req.dto.ts
+++ b/libs/dtos/src/dtos/requests/creddef.req.dto.ts
@@ -1,9 +1,5 @@
import { IsNotEmpty, IsString } from "class-validator";
-// INFO: should cover:
-
-// 1. get credential definition request
-
export class CreddefReqDto {
@IsNotEmpty()
diff --git a/libs/dtos/src/dtos/requests/credential.req.dto.ts b/libs/dtos/src/dtos/requests/credential.req.dto.ts
index c2b6dcd8..f94a2682 100644
--- a/libs/dtos/src/dtos/requests/credential.req.dto.ts
+++ b/libs/dtos/src/dtos/requests/credential.req.dto.ts
@@ -1,14 +1,6 @@
import { IsNotEmpty, IsString } from "class-validator";
-
-// INFO: should cover:
-
-// 1. accept credential request
-// 2. get credential request
-
-
-
export class CredentialReqDto {
//@example cf8395a5-9a53-4e06-8a5d-04e0fc00ca04
@IsNotEmpty()
diff --git a/libs/dtos/src/dtos/requests/proof.req.dto.ts b/libs/dtos/src/dtos/requests/proof.req.dto.ts
index 01009922..e67c1819 100644
--- a/libs/dtos/src/dtos/requests/proof.req.dto.ts
+++ b/libs/dtos/src/dtos/requests/proof.req.dto.ts
@@ -1,12 +1,6 @@
import { IsNotEmpty, IsString, ValidateIf } from "class-validator";
-// INFO: should cover:
-
-// 1. get proof request
-// 2. decline proof request
-// 3. accept proof request
-
export class ProofReqDto {
@IsString()
@IsNotEmpty()
diff --git a/libs/dtos/src/dtos/requests/schema.req.dto.ts b/libs/dtos/src/dtos/requests/schema.req.dto.ts
index 6902b704..4bf2cb6c 100644
--- a/libs/dtos/src/dtos/requests/schema.req.dto.ts
+++ b/libs/dtos/src/dtos/requests/schema.req.dto.ts
@@ -1,10 +1,6 @@
import { IsNotEmpty, IsString } from "class-validator";
-// INFO: should cover:
-
-// 1. get schema request
-
export class SchemaReqDto {
//@example "did:indy:LEDNGER:SXM76gQwRnjkgoz2oBnGjd/anoncreds/v0/SCHEMA/test schema/1.0.2"
@IsNotEmpty()
--
GitLab