The real bug was setting the source of the ticket form — not the fallback to
the form entry source.  Falling back breaks edits.

Also fix a crash when re-rendering the new ticket by staff page after a
validation error.

Bug: attachments

Reviewed-By: Jared Hancock <jared@osticket.com>

Fix Additional XSS Vulnerability In "tpl.inc.php"

Reviewed-By: Peter Rotich <peter@osticket.com>

forms: oops: Properly validate forms for agents

Reviewed-By: Peter Rotich <peter@osticket.com>

users: Error message setting username to an email

Reviewed-By: Peter Rotich <peter@osticket.com>

forms: If an answer has no saved value, use the field

Reviewed-By: Peter Rotich <peter@osticket.com>

User Directory not sortable by Status

Reviewed-By: Peter Rotich <peter@osticket.com>

pjax: Fix placement of footer

Reviewed-By: Peter Rotich <peter@osticket.com>

oops: Fix bad merge for list properties as sub-fields

Reviewed-By: Peter Rotich <peter@osticket.com>

i18n: Fix several issues with right-to-left layout

Reviewed-By: Peter Rotich <peter@osticket.com>

oops: Properly format text thread bodies

Reviewed-By: Peter Rotich <peter@osticket.com>

Fixes https://github.com/osTicket/osTicket-1.8/issues/1277 and https://github.com/osTicket/osTicket-1.8/issues/1373

This patch fixes a small glitch where validation might be bypassed for
fields for agents. Previously there was a glitch where required fields would
have their validation errors ignored.

Since users can already log in via their email address, offer a friendly
error message when agents configure the user name to be an email address.

Footer should not be in #pjax_container, because the footer is not rendered
for non PJAX requests.

When processing the value of a DynamicFormEntryAnswer, if there is no
database-backed, value, then use the value of the associated field.

Auto-detect inline attachments
Attached keepers to canned reply

This patch also makes a slight edit to mPDF to allow better detection of
substitions in characters, as the DejaVu fonts shipped do not support Thai
glyphs.

forms: Add default selection to SelectionField

Reviewed-By: Peter Rotich <peter@osticket.com>

This allows administrators to select a default value for selection fields
deriving from Custom Lists. This has been implemented on the ChoiceField,
but was forgotten on the SelectionField