From ddde34b08fc442539d9aeeb8f81ef41b342b0fdd Mon Sep 17 00:00:00 2001
From: JediKev <kevin@enhancesoft.com>
Date: Fri, 20 Sep 2019 10:35:31 -0500
Subject: [PATCH] issue: Revert 453e815
This addresses an issue where upgrading from v1.6 to a release on or after
v1.12 will hang on login and eventually timeout. This is due to the system
not being able to fetch the config which logs a db error which calls the
config and continues the loop. For now, we need the config in the
constructor so that the loop doesn't occur and we can continue to upgrade as
normal.
TODO:
- For a permanent fix, we need to figure out why the loop occurs when not in
the constructor and vice versa.
---
include/class.osticket.php | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/class.osticket.php b/include/class.osticket.php
index fbaaace07..4ad07de0e 100644
--- a/include/class.osticket.php
+++ b/include/class.osticket.php
@@ -59,6 +59,7 @@ class osTicket {
if (!defined('DISABLE_SESSION') || !DISABLE_SESSION)
$this->session = osTicketSession::start(SESSION_TTL); // start DB based session
+ $this->config = new OsticketConfig();
$this->csrf = new CSRF('__CSRFToken__');
@@ -84,9 +85,6 @@ class osTicket {
}
function getConfig() {
- if (!isset($this->config))
- $this->config = new OsticketConfig();
-
return $this->config;
}
--
GitLab