From c846db53496adbb6f4929a406f111fc4e72429bf Mon Sep 17 00:00:00 2001
From: Peter Rotich <peter@osticket.com>
Date: Thu, 31 Mar 2016 02:34:47 +0000
Subject: [PATCH] dept: Check Agent's Membership

isMember routine wrongly assumed getMembers returned staff_id indexed
hashtable.
---
 include/class.dept.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/class.dept.php b/include/class.dept.php
index 397df89c4..0d26f12a0 100644
--- a/include/class.dept.php
+++ b/include/class.dept.php
@@ -305,10 +305,10 @@ implements TemplateVariable {
         if (is_object($staff))
             $staff = $staff->getId();
 
-        // Members are indexed by ID
-        $members = $this->getMembers();
+        $members = $this->getMembers() ?: $this->members;
 
-        return ($members && isset($members[$staff]));
+        return ($members->findFirst(array(
+                        'staff_id' => $staff)));
     }
 
     function isPublic() {
-- 
GitLab