From bff0647f4baf69101b73d135743748927a775aaf Mon Sep 17 00:00:00 2001 From: JediKev <kevin@enhancesoft.com> Date: Wed, 13 Feb 2019 14:03:29 -0600 Subject: [PATCH] issue: No Save Button On Quicknotes This addresses issue 4725 where there is no save button when editing a quick note. This is due to the jQuery update which changed how a few things work with redactor. --- scp/js/scp.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scp/js/scp.js b/scp/js/scp.js index b25402597..de9cd7d4e 100644 --- a/scp/js/scp.js +++ b/scp/js/scp.js @@ -1116,15 +1116,16 @@ $(document).on('change', 'select[data-quick-add]', function() { }); // Quick note interface -$(document).on('click.note', '.quicknote .action.edit-note', function() { +$(document).on('click.note', '.quicknote .action.edit-note', function(e) { + // Prevent Auto-Scroll to top of page + e.preventDefault(); var note = $(this).closest('.quicknote'), body = note.find('.body'), T = $('<textarea>').text(body.html()); if (note.closest('.dialog, .tip_box').length) T.addClass('no-bar small'); body.replaceWith(T); - $.redact(T); - $(T).redactor('focus.setStart'); + $.redact(T, { focusEnd: true }); note.find('.action.edit-note').hide(); note.find('.action.save-note').show(); note.find('.action.cancel-edit').show(); @@ -1197,8 +1198,7 @@ $(document).on('click', '#new-note', function() { note.replaceWith(T); $('<p>').addClass('submit').css('text-align', 'center') .append(button).appendTo(T.parent()); - $.redact(T); - $(T).redactor('focus.setStart'); + $.redact(T, { focusEnd: true }); return false; }); -- GitLab