From bf20bdd5e62a4c11c5ebab92a0adbee735a9bdbd Mon Sep 17 00:00:00 2001
From: JediKev <kevin@enhancesoft.com>
Date: Thu, 9 May 2019 13:10:12 -0500
Subject: [PATCH] cli: Package Better Wording
This updates the variable name that determines if the current PHP version is
5.6+ from `$php56` to `$php56plus`. This will help other understand better
what the variable is/does.
---
include/cli/modules/package.php | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/cli/modules/package.php b/include/cli/modules/package.php
index e1649e778..eedc187c2 100644
--- a/include/cli/modules/package.php
+++ b/include/cli/modules/package.php
@@ -108,8 +108,8 @@ class Packager extends Deployment {
if (!$zip->open($name, ZipArchive::CREATE | ZipArchive::OVERWRITE) === true)
return false;
- $php56 = version_compare(phpversion(), '5.6.0', '>');
- $addFiles = function($dir) use (&$addFiles, $zip, $path, $php56) {
+ $php56plus = version_compare(phpversion(), '5.6.0', '>');
+ $addFiles = function($dir) use (&$addFiles, $zip, $path, $php56plus) {
$files = array_diff(scandir($dir), array('.','..'));
$path = rtrim($path, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR;
foreach ($files as $file) {
@@ -122,7 +122,7 @@ class Packager extends Deployment {
// out of OS open file handles
$zip->addFromString($local, file_get_contents($full));
// This only works on PHP >= v5.6
- if ($php56) {
+ if ($php56plus) {
// Set the Unix mode of the file
$stat = stat($full);
$zip->setExternalAttributesName($local, ZipArchive::OPSYS_UNIX, $stat['mode'] << 16);
--
GitLab