From 92e5a8f5aacd32193e79ff10efc18b9517f83d3d Mon Sep 17 00:00:00 2001
From: Jared Hancock <jared@osticket.com>
Date: Mon, 16 Jun 2014 16:33:47 -0500
Subject: [PATCH] Fix XSS vulnerability in phone number field
---
include/class.forms.php | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/class.forms.php b/include/class.forms.php
index ded5e7663..c3396edab 100644
--- a/include/class.forms.php
+++ b/include/class.forms.php
@@ -1017,12 +1017,13 @@ class PhoneNumberWidget extends Widget {
list($phone, $ext) = explode("X", $this->value);
?>
<input type="text" name="<?php echo $this->name; ?>" value="<?php
- echo $phone; ?>"/><?php
+ echo Format::htmlchars($phone); ?>"/><?php
// Allow display of extension field even if disabled if the phone
// number being edited has an extension
if ($ext || $config['ext']) { ?> Ext:
<input type="text" name="<?php
- echo $this->name; ?>-ext" value="<?php echo $ext; ?>" size="5"/>
+ echo $this->name; ?>-ext" value="<?php echo Format::htmlchars($ext);
+ ?>" size="5"/>
<?php }
}
--
GitLab