From 735bb203772d166c2b98b574aef7615eb3d2f8aa Mon Sep 17 00:00:00 2001
From: Jared Hancock <jared@osticket.com>
Date: Sun, 24 Apr 2016 16:51:13 -0500
Subject: [PATCH] oops: Fix call to missing create(), only fetch user form once
---
include/ajax.sequence.php | 2 +-
include/staff/dynamic-form.inc.php | 9 +++++----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/ajax.sequence.php b/include/ajax.sequence.php
index 299e8c322..ed292c51c 100644
--- a/include/ajax.sequence.php
+++ b/include/ajax.sequence.php
@@ -67,7 +67,7 @@ class SequenceAjaxAPI extends AjaxController {
foreach ($_POST['seq'] as $id=>$info) {
if (strpos($id, 'new-') === 0) {
unset($info['id']);
- $sequences[] = Sequence::create($info);
+ $sequences[] = new Sequence($info);
}
else {
foreach ($sequences as $s) {
diff --git a/include/staff/dynamic-form.inc.php b/include/staff/dynamic-form.inc.php
index f1bba8396..775e05879 100644
--- a/include/staff/dynamic-form.inc.php
+++ b/include/staff/dynamic-form.inc.php
@@ -114,14 +114,16 @@ if ($form && count($langs) > 1) { ?>
</tbody>
</table>
<table class="form_table" width="940" border="0" cellspacing="0" cellpadding="2">
- <?php if ($form && $form->get('type') == 'T') { ?>
+ <?php if ($form && $form->get('type') == 'T') {
+ $uform = UserForm::objects()->one();
+ ?>
<thead>
<tr>
<th colspan="7">
<em><strong><?php echo __('User Information Fields'); ?></strong>
<?php echo sprintf(__('(These fields are requested for new tickets
via the %s form)'),
- UserForm::objects()->one()->get('title')); ?></em>
+ $uform->get('title')); ?></em>
</th>
</tr>
<tr>
@@ -135,9 +137,8 @@ if ($form && count($langs) > 1) { ?>
</thead>
<tbody>
<?php
- $uform = UserForm::objects()->all();
$ftypes = FormField::allTypes();
- foreach ($uform[0]->getFields() as $f) {
+ foreach ($uform->getFields() as $f) {
if (!$f->isVisibleToUsers()) continue;
?>
<tr>
--
GitLab