From 3d98dffbc0f1aeb9007f40deb4926770ff14c518 Mon Sep 17 00:00:00 2001
From: Jared Hancock <jared@osticket.com>
Date: Wed, 8 Jul 2015 13:19:14 -0500
Subject: [PATCH] filter: Shop filter full path help topics

---
 include/class.topic.php      | 2 +-
 include/staff/filter.inc.php | 9 +++------
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/include/class.topic.php b/include/class.topic.php
index 9139f9e6d..a59d36610 100644
--- a/include/class.topic.php
+++ b/include/class.topic.php
@@ -297,7 +297,7 @@ class Topic {
             if (!$disabled && $info['disabled'])
                 continue;
             if ($disabled === self::DISPLAY_DISABLED && $info['disabled'])
-                $n .= " &mdash; ".__("(disabled)");
+                $n .= " - ".__("(disabled)");
             $requested_names[$id] = $n;
         }
 
diff --git a/include/staff/filter.inc.php b/include/staff/filter.inc.php
index 97bc1a995..0273f2bc2 100644
--- a/include/staff/filter.inc.php
+++ b/include/staff/filter.inc.php
@@ -368,12 +368,9 @@ $info=Format::htmlchars(($errors && $_POST)?$_POST:$info);
                     <option value="0" selected="selected">&mdash; <?php
                         echo __('Unchanged'); ?> &mdash;</option>
                     <?php
-                    $sql='SELECT topic_id, topic FROM '.TOPIC_TABLE.' T ORDER by topic';
-                    if(($res=db_query($sql)) && db_num_rows($res)){
-                        while(list($id,$name)=db_fetch_row($res)){
-                            $selected=($info['topic_id'] && $id==$info['topic_id'])?'selected="selected"':'';
-                            echo sprintf('<option value="%d" %s>%s</option>',$id,$selected,$name);
-                        }
+                    foreach (Topic::getHelpTopics(false, Topic::DISPLAY_DISABLED) as $id=>$name) {
+                        $selected=($info['topic_id'] && $id==$info['topic_id'])?'selected="selected"':'';
+                        echo sprintf('<option value="%d" %s>%s</option>',$id,$selected,$name);
                     }
                     ?>
                 </select>
-- 
GitLab