From 37cdf2583211da568b75e99182d0901991963c7c Mon Sep 17 00:00:00 2001
From: Jared Hancock <jared@osticket.com>
Date: Wed, 5 Aug 2015 09:04:25 -0500
Subject: [PATCH] lock: Acquire a lazy lock for internal note posting
Fixes #2371
---
include/staff/ticket-view.inc.php | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/include/staff/ticket-view.inc.php b/include/staff/ticket-view.inc.php
index 685661abf..967228946 100644
--- a/include/staff/ticket-view.inc.php
+++ b/include/staff/ticket-view.inc.php
@@ -469,14 +469,14 @@ $tcount = $ticket->getThreadEntries($types)->count();
if ($role->hasPerm(TicketModel::PERM_REPLY)) { ?>
<form id="reply" class="tab_content spellcheck exclusive"
data-lock-object-id="ticket/<?php echo $ticket->getId(); ?>"
- data-lock-id="<?php echo ($mylock) ? $mylock->getId() : ''; ?>"
+ data-lock-id="<?php echo $mylock ? $mylock->getId() : ''; ?>"
action="tickets.php?id=<?php
echo $ticket->getId(); ?>" name="reply" method="post" enctype="multipart/form-data">
<?php csrf_token(); ?>
<input type="hidden" name="id" value="<?php echo $ticket->getId(); ?>">
<input type="hidden" name="msgId" value="<?php echo $msgId; ?>">
<input type="hidden" name="a" value="reply">
- <input type="hidden" name="lockCode" value="<?php echo ($mylock) ? $mylock->getCode() : ''; ?>">
+ <input type="hidden" name="lockCode" value="<?php echo $mylock ? $mylock->getCode() : ''; ?>">
<span class="error"></span>
<table style="width:100%" border="0" cellspacing="0" cellpadding="3">
<tbody id="to_sec">
@@ -659,13 +659,16 @@ $tcount = $ticket->getThreadEntries($types)->count();
</form>
<?php
} ?>
- <form id="note" class="hidden tab_content spellcheck" action="tickets.php?id=<?php
- echo $ticket->getId(); ?>#note" name="note" method="post" enctype="multipart/form-data">
+ <form id="note" class="hidden tab_content spellcheck exclusive"
+ data-lock-object-id="ticket/<?php echo $ticket->getId(); ?>"
+ data-lock-id="<?php echo $mylock ? $mylock->getId() : ''; ?>"
+ action="tickets.php?id=<?php echo $ticket->getId(); ?>#note"
+ name="note" method="post" enctype="multipart/form-data">
<?php csrf_token(); ?>
<input type="hidden" name="id" value="<?php echo $ticket->getId(); ?>">
<input type="hidden" name="locktime" value="<?php echo $cfg->getLockTime() * 60; ?>">
<input type="hidden" name="a" value="postnote">
- <input type="hidden" name="lockCode" value="<?php echo ($mylock) ? $mylock->getCode() : ''; ?>">
+ <input type="hidden" name="lockCode" value="<?php echo $mylock ? $mylock->getCode() : ''; ?>">
<table width="100%" border="0" cellspacing="0" cellpadding="3">
<?php
if($errors['postnote']) {?>
--
GitLab