diff --git a/include/class.config.php b/include/class.config.php index 004a1e8e8a44d2be9fdcc1cde54acd0a03300d73..d7518a91f947786ba15ba69a345f5ee2018a7281 100644 --- a/include/class.config.php +++ b/include/class.config.php @@ -30,10 +30,6 @@ class Config { # new settings and the corresponding default values. var $defaults = array(); # List of default values - - # Items - var $items = null; - function __construct($section=null, $defaults=array()) { if ($section) $this->section = $section; @@ -133,18 +129,11 @@ class Config { function destroy() { unset($this->session); - if ($this->items) - $this->items->delete(); - - return true; + return $this->items()->delete() > 0; } function items() { - - if (!isset($this->items)) - $this->items = ConfigItem::items($this->section, $this->section_column); - - return $this->items; + return ConfigItem::items($this->section, $this->section_column); } } diff --git a/include/cli/modules/upgrade.php b/include/cli/modules/upgrade.php index 297d6d56f84d36dcdc1ad23c42410a09d483b165..383c47f5c66226ac32f6ae102f502e27fcbe1645 100644 --- a/include/cli/modules/upgrade.php +++ b/include/cli/modules/upgrade.php @@ -51,12 +51,12 @@ class CliUpgrader extends Module { $cfg = $ost->getConfig(); while (true) { - if ($upgrader->getTask()) { - // If there's anythin in the model cache (like a Staff - // object or something), ensure that changes to the database - // model won't cause crashes - ModelInstanceManager::flushCache(); + // If there's anythin in the model cache (like a Staff + // object or something), ensure that changes to the database + // model won't cause crashes + ModelInstanceManager::flushCache(); + if ($upgrader->getTask()) { // More pending tasks - doTasks returns the number of pending tasks $this->stdout->write("... {$upgrader->getNextAction()}\n"); $upgrader->doTask();