From 0a52aac88ec2f0868c3d4c60ba43b7cabe1b658e Mon Sep 17 00:00:00 2001 From: Jared Hancock <jared@osticket.com> Date: Tue, 21 Jul 2015 10:00:08 -0500 Subject: [PATCH] xss: Properly escape choices when rendered --- include/class.forms.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/class.forms.php b/include/class.forms.php index e17844469..43d1416ff 100644 --- a/include/class.forms.php +++ b/include/class.forms.php @@ -1920,7 +1920,7 @@ class ChoicesWidget extends Widget { continue; ?> <option value="<?php echo $key; ?>" <?php if (isset($values[$key])) echo 'selected="selected"'; - ?>><?php echo $name; ?></option> + ?>><?php echo Format::htmlchars($name); ?></option> <?php } ?> </select> <?php -- GitLab