From 05ab66b6702dd2c57de19d5e90065d9fcaec5dda Mon Sep 17 00:00:00 2001 From: JediKev <kevin@enhancesoft.com> Date: Wed, 29 Aug 2018 10:45:47 -0500 Subject: [PATCH] accessibility: Screen Readable Actions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This improves accessibility by adding screen readable labels to ticket actions that don’t already have them. --- include/staff/templates/status-options.tmpl.php | 1 + include/staff/templates/tickets-actions.tmpl.php | 1 + include/staff/ticket-view.inc.php | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/staff/templates/status-options.tmpl.php b/include/staff/templates/status-options.tmpl.php index 3b493f379..9dadccafa 100644 --- a/include/staff/templates/status-options.tmpl.php +++ b/include/staff/templates/status-options.tmpl.php @@ -37,6 +37,7 @@ if (!$nextStatuses) data-dropdown="#action-dropdown-statuses" data-placement="bottom" data-toggle="tooltip" title="<?php echo __('Change Status'); ?>"> <i class="icon-caret-down pull-right"></i> <a class="tickets-action" + aria-label="<?php echo __('Change Status'); ?>" href="#statuses"><i class="icon-flag"></i></a> </span> diff --git a/include/staff/templates/tickets-actions.tmpl.php b/include/staff/templates/tickets-actions.tmpl.php index 0535a5af2..55a695cd3 100644 --- a/include/staff/templates/tickets-actions.tmpl.php +++ b/include/staff/templates/tickets-actions.tmpl.php @@ -14,6 +14,7 @@ if ($agent->hasPerm(Ticket::PERM_ASSIGN, false)) {?> echo __('Assign'); ?>"> <i class="icon-caret-down pull-right"></i> <a class="tickets-action" id="tickets-assign" + aria-label="<?php echo __('Assign'); ?>" href="#tickets/mass/assign"><i class="icon-user"></i></a> </span> <div id="action-dropdown-assign" class="action-dropdown anchor-right"> diff --git a/include/staff/ticket-view.inc.php b/include/staff/ticket-view.inc.php index 21d6cf62b..cdf4afd20 100644 --- a/include/staff/ticket-view.inc.php +++ b/include/staff/ticket-view.inc.php @@ -74,7 +74,7 @@ if($ticket->isOverdue()) } ?> <span class="action-button pull-right" data-placement="bottom" data-dropdown="#action-dropdown-print" data-toggle="tooltip" title="<?php echo __('Print'); ?>"> <i class="icon-caret-down pull-right"></i> - <a id="ticket-print" href="tickets.php?id=<?php echo $ticket->getId(); ?>&a=print"><i class="icon-print"></i></a> + <a id="ticket-print" aria-label="<?php echo __('Print'); ?>" href="tickets.php?id=<?php echo $ticket->getId(); ?>&a=print"><i class="icon-print"></i></a> </span> <div id="action-dropdown-print" class="action-dropdown anchor-right"> <ul> -- GitLab