From 000204d635dfdc3ea7067387f12c14aad68a9e24 Mon Sep 17 00:00:00 2001
From: Peter Rotich <peter@osticket.com>
Date: Thu, 28 Jun 2012 00:27:17 -0400
Subject: [PATCH] Limit stats query to v1.7+ & Make sure getDepts is not empty
---
include/class.ticket.php | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/class.ticket.php b/include/class.ticket.php
index 6b933239d..80b6a60ac 100644
--- a/include/class.ticket.php
+++ b/include/class.ticket.php
@@ -1751,7 +1751,7 @@ class Ticket{
global $cfg;
/* Unknown or invalid staff */
- if(!$staff || (!is_object($staff) && !($staff=Staff::lookup($staff))) || !$staff->isStaff())
+ if(!$staff || (!is_object($staff) && !($staff=Staff::lookup($staff))) || !$staff->isStaff() || $cfg->getDBVersion())
return null;
@@ -1773,12 +1773,11 @@ class Ticket{
if(($teams=$staff->getTeams()))
$sql.=' OR ticket.team_id IN('.implode(',', array_filter($teams)).')';
- if(!$staff->showAssignedOnly()) //Staff with limited access just see Assigned tickets.
- $sql.=' OR ticket.dept_id IN('.implode(',',$staff->getDepts()).') ';
+ if(!$staff->showAssignedOnly() && ($depts=$staff->getDepts())) //Staff with limited access just see Assigned tickets.
+ $sql.=' OR ticket.dept_id IN('.implode(',', $depts).') ';
$sql.=')';
-
if(!$cfg || !($cfg->showAssignedTickets() || $staff->showAssignedTickets()))
$sql.=' AND (ticket.staff_id=0 OR ticket.staff_id='.db_input($staff->getId()).') ';
--
GitLab