Skip to content
Snippets Groups Projects
  • Jared Hancock's avatar
    ada4d9a0
    filters: Fix several small, major issues · ada4d9a0
    Jared Hancock authored
      * Fix incorrect mapping to user email address
      * Fix early rejecting of tickets — even if a filter earlier in the
        matching filter list had "stop on match" set
      * Fix ::stopOnMatch referring to incorrect db field
    
    The new logic abandons the early rejection logic in ticket create. Instead,
    the normal validation is completed as usual. Thereafter, the filter is
    initialized and applied to the ticket. Upon rejection, a RejectedException
    is thrown by the ::apply() method of the TicketFilter. The Ticket::create()
    method will handle the exception and reject the ticket.
    ada4d9a0
    History
    filters: Fix several small, major issues
    Jared Hancock authored
      * Fix incorrect mapping to user email address
      * Fix early rejecting of tickets — even if a filter earlier in the
        matching filter list had "stop on match" set
      * Fix ::stopOnMatch referring to incorrect db field
    
    The new logic abandons the early rejection logic in ticket create. Instead,
    the normal validation is completed as usual. Thereafter, the filter is
    initialized and applied to the ticket. Upon rejection, a RejectedException
    is thrown by the ::apply() method of the TicketFilter. The Ticket::create()
    method will handle the exception and reject the ticket.