From c807203093315d8814484bc24825c3eda5f232ba Mon Sep 17 00:00:00 2001
From: igor <igor.markin@vereign.com>
Date: Wed, 23 Dec 2020 19:23:56 +0300
Subject: [PATCH] Finish coverage of the plain
---
.../outlook-outlook/macos-macos/README.md | 10 ++--
.../outlook-outlook/windows-windows/README.md | 56 ++++++++++++-------
__tests__/plain-outlook-outlook.test.ts | 26 +++------
3 files changed, 50 insertions(+), 42 deletions(-)
diff --git a/__tests__/files/outlook-outlook/macos-macos/README.md b/__tests__/files/outlook-outlook/macos-macos/README.md
index 0a1c3b0..8bc7a08 100644
--- a/__tests__/files/outlook-outlook/macos-macos/README.md
+++ b/__tests__/files/outlook-outlook/macos-macos/README.md
@@ -2,13 +2,13 @@
| ----------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | --------------- | ---------------- | -------------------- |
| 01 | Empty body | ok | ok | ok |
| 02 | Simple text | ok | ok | ok |
-| 03 | Embedded image | fail | - | fail |
-| 04 | Embedded image with text | fail | - | fail |
-| 05 | Complex text on multiple lines with some text bold, italic, lists, no attachments | fail | - | - |
+| 03 | Embedded image | fail | ok | fail |
+| 04 | Embedded image with text | fail | ok | fail |
+| 05 | Complex text on multiple lines with some text bold, italic, lists, no attachments | fail | ok | - |
| 06 | Multiple MIME attachments and text | ok | ok | ok |
| 07 | Multiple Drive attachments and text | ok | ok | ok |
-| 08 | Complex email with formatted text, embedded images, MIME and GDrive attachments | fail | - | - |
-| 09 | 2 replies with test case 01 | fail | - | - |
+| 08 | Complex email with formatted text, embedded images, MIME and GDrive attachments | fail | ok | - |
+| 09 | 2 replies with test case 01 | fail | ok | - |
| 10 | 2 replies with test case 02 | - | - | - |
| 11 | 2 replies with test case 03 | - | - | - |
| 12 | 2 replies with test case 04 | - | - | - |
diff --git a/__tests__/files/outlook-outlook/windows-windows/README.md b/__tests__/files/outlook-outlook/windows-windows/README.md
index 5323495..88fc98c 100644
--- a/__tests__/files/outlook-outlook/windows-windows/README.md
+++ b/__tests__/files/outlook-outlook/windows-windows/README.md
@@ -1,28 +1,34 @@
| Test Number | Description | HTML validation | Plain validation | HTML text validation |
| ----------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | --------------- | ---------------- | -------------------- |
-| 01 | Empty body | ok | - | - |
-| 02 | Simple text | ok | - | - |
-| 03 | Embedded image | ok | - | - |
-| 04 | Embedded image with text | ok | - | - |
-| 05 | Complex text on multiple lines with some text bold, italic, lists, no attachments | ok | - | - |
-| 06 | Multiple MIME attachments and text | ok | - | - |
-| 07 | Multiple Drive attachments and text | ok | - | - |
-| 08 | Complex email with formatted text, embedded images, MIME and GDrive attachments | ok | - | - |
-| 09 | 2 replies with test case 01 | ok | - | - |
-| 10 | 2 replies with test case 02 | ok | - | - |
-| 11 | 2 replies with test case 03 | fail | - | - |
-| 12 | 2 replies with test case 04 | fail | - | - |
-| 13 | 2 replies with test case 05 | fail | - | - |
-| 14 | 2 replies with test case 06 | ok | - | - |
-| 15 | 2 replies with test case 07 | ok | - | - |
-| 16 | 2 replies with test case 08 | fail | - | - |
+| 01 | Empty body | ok | ok | - |
+| 02 | Simple text | ok | ok | - |
+| 03 | Embedded image | ok | ok | - |
+| 04 | Embedded image with text | ok | ok | - |
+| 05 | Complex text on multiple lines with some text bold, italic, lists, no attachments | ok | ok | - |
+| 06 | Multiple MIME attachments and text | ok | ok | - |
+| 07 | Multiple Drive attachments and text | ok | ok | - |
+| 08 | Complex email with formatted text, embedded images, MIME and GDrive attachments | ok | ok | - |
+| 09 | 2 replies with test case 01 | ok | fail | - |
+| 10 | 2 replies with test case 02 | ok | fail | - |
+| 11 | 2 replies with test case 03 | fail | fail | - |
+| 12 | 2 replies with test case 04 | fail | fail | - |
+| 13 | 2 replies with test case 05 | fail | fail | - |
+| 14 | 2 replies with test case 06 | ok | fail | - |
+| 15 | 2 replies with test case 07 | ok | fail | - |
+| 16 | 2 replies with test case 08 | fail | fail | - |
| 17 | Multiple forwarded emails using cases 01-08:<br><br>E.g. <br>- User A sends "case 01" to User B<br>- User B forwards "case 02" to User A<br>- User A forwards "case 03" to User B<br>...<br>- User B forwards "case 08" to User A<br>- User A completes circle by forwarding "case 01" to User B | - | - | - |
## Failing cases
+### 09, 10
+
+**Plain**
+
+`received.eml` is missing QR code images because of the bug with Exchange server and messes QR code urls:
+
### 11, 12
-#### HTML
+**HTML, Plain, pseudoplain**
`<img>` with the same picture gets different `cid` values. Relevant base64 strings are also different.
@@ -35,7 +41,7 @@ Diff sample
### 13
-#### HTML
+**HTML**
Outlook amending HTML structure of the formatted text
@@ -60,8 +66,18 @@ Diff sample
+ <UL>
```
+**Plain**
+
+`received.eml` is missing QR code images because of the bug with Exchange server and messes QR code urls:
+
+### 14, 15
+
+**Plain**
+
+`received.eml` is missing QR code images because of the bug with Exchange server and messes QR code urls:
+
### 16
-#### HTML
+**HTML and Plain**
-A combination of factors 11, 12 and 13
+A combination of all factors above
diff --git a/__tests__/plain-outlook-outlook.test.ts b/__tests__/plain-outlook-outlook.test.ts
index 43fac98..7412266 100644
--- a/__tests__/plain-outlook-outlook.test.ts
+++ b/__tests__/plain-outlook-outlook.test.ts
@@ -9,26 +9,18 @@ const testsPath = path.resolve(__dirname, `.${TESTS_GLOBAL_PATH}`);
describe("[Plain] Outlook-Outlook normalization", () => {
const describeFunction = createDescribePlainTestCases(testsPath);
describe("Chrome-Chrome", describeFunction("chrome-chrome", ["16"]));
- describe("MacOS-MacOS", describeFunction("macos-macos", null));
+ describe("MacOS-MacOS", describeFunction("macos-macos"));
describe(
"Windows-Windows",
describeFunction("windows-windows", [
- "06", // mismatch of sent and received emls. Passing though )
- "08", // mismatch of sent and received emls. Passing though )
- ])
- );
- describe(
- "Windows-MacOS",
- describeFunction("windows-macos", [
- "06", // mismatch of sent and received emls. Passing though )
- "08", // mismatch of sent and received emls. Passing though )
- ])
- );
- describe(
- "Windows-Chrome",
- describeFunction("windows-chrome", [
- "06", // mismatch of sent and received emls. Passing though )
- "08", // mismatch of sent and received emls. Passing though )
+ "09",
+ "10",
+ "11",
+ "12",
+ "13",
+ "14",
+ "15",
+ "16",
])
);
});
--
GitLab